| Message ID | 20241202-dt-bcm2712-fixes-v1-7-fac67cc2f98a@raspberrypi.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/vc4: Fixup DT and DT binding issues from recent patchset | expand |
On 02/12/2024 15:32, Dave Stevenson wrote: > Resolves the issues on clocks and power nodes Which issues? Be specific. Such commit is unprecise and not really helpful. We see it from the diff that this is "some issue". What we do not see is WHY and WHAT the ISSUE is. > > Fixes: 4254a647b6c9 ("arm64: dts: broadcom: Add firmware clocks and power nodes to Pi5 DT") > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Nothing in the DTS patches suggested targeting DRM, so this patchset is organized in pretty surprising way. Please split them per subsystem. DTS is never for driver subsystem. Subject: drop full stop. > --- > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > index fbc56309660f..26e05601416f 100644 > --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > @@ -66,11 +66,7 @@ &sdio1 { > &soc { > firmware: firmware { > compatible = "raspberrypi,bcm2835-firmware", "simple-mfd"; > - #address-cells = <1>; > - #size-cells = <1>; > - > mboxes = <&mailbox>; > - dma-ranges; > > firmware_clocks: clocks { > compatible = "raspberrypi,firmware-clocks"; > @@ -85,6 +81,11 @@ reset: reset { > > power: power { > compatible = "raspberrypi,bcm2835-power"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + dma-ranges; No address space here, so why ranges? > + > firmware = <&firmware>; > #power-domain-cells = <1>; > }; > Best regards, Krzysztof
On 12/2/24 07:24, Krzysztof Kozlowski wrote: > On 02/12/2024 15:32, Dave Stevenson wrote: >> Resolves the issues on clocks and power nodes > > Which issues? Be specific. Such commit is unprecise and not really > helpful. We see it from the diff that this is "some issue". What we do > not see is WHY and WHAT the ISSUE is. A link to the robot email would have probably been helpful in understanding which dt checker errors are being fixed here. Regardless, as indicated in patch #4, those commit messages will be discarded since I intend to fixup the original commits directly into my tree I would not put too much effort into addressing any comments there, unless there is some piece of information that should have been provided in the original commit, in which case I can squash, rather than fixup.
diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts index fbc56309660f..26e05601416f 100644 --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts @@ -66,11 +66,7 @@ &sdio1 { &soc { firmware: firmware { compatible = "raspberrypi,bcm2835-firmware", "simple-mfd"; - #address-cells = <1>; - #size-cells = <1>; - mboxes = <&mailbox>; - dma-ranges; firmware_clocks: clocks { compatible = "raspberrypi,firmware-clocks"; @@ -85,6 +81,11 @@ reset: reset { power: power { compatible = "raspberrypi,bcm2835-power"; + #address-cells = <1>; + #size-cells = <1>; + ranges; + dma-ranges; + firmware = <&firmware>; #power-domain-cells = <1>; };
Resolves the issues on clocks and power nodes Fixes: 4254a647b6c9 ("arm64: dts: broadcom: Add firmware clocks and power nodes to Pi5 DT") Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> --- arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)