| Message ID | 20241212091153.1592096-1-jfalempe@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/client: Fix drm client endless Kconfig loop | expand |
On 12/12/2024 10:11, Jocelyn Falempe wrote: > if DRM_CLIENT_SELECTION is enabled, and none of the client is, the > "Default DRM Client" choice is empty, and this makes Kconfig goes > into an infinite loop of: > > Default DRM Client > choice[1-0?]: 0 > Default DRM Client > choice[1-0?]: 0 > Default DRM Client > choice[1-0?]: 0 > .... > > So only allow the choice if at least one of the client is selected. I've pushed it to drm-misc-next, endless Kconfig loop is not fun for CI. Best regards,
diff --git a/drivers/gpu/drm/clients/Kconfig b/drivers/gpu/drm/clients/Kconfig index c18decc90200..82a7d4e584dd 100644 --- a/drivers/gpu/drm/clients/Kconfig +++ b/drivers/gpu/drm/clients/Kconfig @@ -87,6 +87,7 @@ config DRM_CLIENT_LOG choice prompt "Default DRM Client" depends on DRM_CLIENT_SELECTION + depends on DRM_FBDEV_EMULATION || DRM_CLIENT_LOG default DRM_CLIENT_DEFAULT_FBDEV help Selects the default drm client.
if DRM_CLIENT_SELECTION is enabled, and none of the client is, the "Default DRM Client" choice is empty, and this makes Kconfig goes into an infinite loop of: Default DRM Client choice[1-0?]: 0 Default DRM Client choice[1-0?]: 0 Default DRM Client choice[1-0?]: 0 .... So only allow the choice if at least one of the client is selected. Fixes: f7b42442c4ac ("drm/log: Introduce a new boot logger to draw the kmsg on the screen") Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com> Tested-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/gpu/drm/clients/Kconfig | 1 + 1 file changed, 1 insertion(+) base-commit: 19851fa2ba9824bede16f55234f63d9423897c3d