| Message ID | 20241216-drm-small-improvements-v3-2-78bbc95ac776@bootlin.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | DRM: small improvements | expand |
On 16/12/24 - 17:40, Luca Ceresoli wrote: > This message reports a mismatch between new_crtc_state->enable and > has_connectors, which should be either both true or both false. However it > does not mention which one is true and which is false, which can be useful > for debugging. Add the value of both avriables to the log message. > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Acked-by: Louis Chauvet <louis.chauvet@bootlin.com> > --- > drivers/gpu/drm/drm_atomic_helper.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > index 43cdf39019a44537794cc5a519d139b0cb77073c..3c3bdef9bcf3c4ffcd861744f6607f317ab0c041 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -666,8 +666,9 @@ drm_atomic_helper_check_modeset(struct drm_device *dev, > } > > if (new_crtc_state->enable != has_connectors) { > - drm_dbg_atomic(dev, "[CRTC:%d:%s] enabled/connectors mismatch\n", > - crtc->base.id, crtc->name); > + drm_dbg_atomic(dev, "[CRTC:%d:%s] enabled/connectors mismatch (%d/%d)\n", > + crtc->base.id, crtc->name, > + new_crtc_state->enable, has_connectors); > > return -EINVAL; > } > > -- > 2.34.1 >
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 43cdf39019a44537794cc5a519d139b0cb77073c..3c3bdef9bcf3c4ffcd861744f6607f317ab0c041 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -666,8 +666,9 @@ drm_atomic_helper_check_modeset(struct drm_device *dev, } if (new_crtc_state->enable != has_connectors) { - drm_dbg_atomic(dev, "[CRTC:%d:%s] enabled/connectors mismatch\n", - crtc->base.id, crtc->name); + drm_dbg_atomic(dev, "[CRTC:%d:%s] enabled/connectors mismatch (%d/%d)\n", + crtc->base.id, crtc->name, + new_crtc_state->enable, has_connectors); return -EINVAL; }