diff mbox series

[RFC,2/2] drm/uapi: Adjust uniform spacing

Message ID 20250108150603.2995709-3-tejas.upadhyay@intel.com (mailing list archive)
State New
Headers show
Series Add UAPI support for low latency hint | expand

Commit Message

Upadhyay, Tejas Jan. 8, 2025, 3:06 p.m. UTC
Extensions in exec queue creation formatted to have uniform
spacing in defines.

Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
---
 include/uapi/drm/xe_drm.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Dixit, Ashutosh Jan. 8, 2025, 5:11 p.m. UTC | #1
On Wed, 08 Jan 2025 07:06:03 -0800, Tejas Upadhyay wrote:
>
> Extensions in exec queue creation formatted to have uniform
> spacing in defines.
>
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
> ---
>  include/uapi/drm/xe_drm.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
> index 62447f5422d8..868dac05c100 100644
> --- a/include/uapi/drm/xe_drm.h
> +++ b/include/uapi/drm/xe_drm.h
> @@ -1108,9 +1108,9 @@ struct drm_xe_vm_bind {
>   *
>   */
>  struct drm_xe_exec_queue_create {
> -#define DRM_XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY		0
> -#define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY		0
> -#define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_TIMESLICE		1
> +#define DRM_XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY	0
> +#define DRM_XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY		0
> +#define DRM_XE_EXEC_QUEUE_SET_PROPERTY_TIMESLICE	1

This is wrong. For the lower 2 #define's are sub-property types of
set_property. The original code is correct.
diff mbox series

Patch

diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
index 62447f5422d8..868dac05c100 100644
--- a/include/uapi/drm/xe_drm.h
+++ b/include/uapi/drm/xe_drm.h
@@ -1108,9 +1108,9 @@  struct drm_xe_vm_bind {
  *
  */
 struct drm_xe_exec_queue_create {
-#define DRM_XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY		0
-#define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY		0
-#define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_TIMESLICE		1
+#define DRM_XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY	0
+#define DRM_XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY		0
+#define DRM_XE_EXEC_QUEUE_SET_PROPERTY_TIMESLICE	1
 	/** @extensions: Pointer to the first extension struct, if any */
 	__u64 extensions;