| Message ID | 20250125064619.8305-11-jim.cromie@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y | expand |
Le 25/01/2025 à 07:45, Jim Cromie a écrit : > In ddebug_apply_class_bitmap(), check for actual changes to the bits > before announcing them, to declutter logs. > > no functional change. > > Signed-off-by: Jim Cromie <jim.cromie@gmail.com> Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com> > --- > lib/dynamic_debug.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c > index 1b2fb6502e61..c27965180a49 100644 > --- a/lib/dynamic_debug.c > +++ b/lib/dynamic_debug.c > @@ -595,7 +595,7 @@ static int ddebug_exec_queries(char *query, const char *modname) > return nfound; > } > > -/* apply a new bitmap to the sys-knob's current bit-state */ > +/* apply a new class-param setting */ > static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, > unsigned long *new_bits, unsigned long *old_bits, > const char *query_modname) > @@ -606,8 +606,9 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, > int matches = 0; > int bi, ct; > > - v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, *old_bits, > - query_modname ?: ""); > + if (*new_bits != *old_bits) > + v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, > + *old_bits, query_modname ?: "'*'"); > > for (bi = 0; bi < map->length; bi++) { > if (test_bit(bi, new_bits) == test_bit(bi, old_bits)) > @@ -622,8 +623,9 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, > v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi, > ct, map->class_names[bi], *new_bits); > } > - v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, *old_bits, > - query_modname ?: ""); > + if (*new_bits != *old_bits) > + v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, > + *old_bits, query_modname ?: "'*'"); > > return matches; > }
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 1b2fb6502e61..c27965180a49 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -595,7 +595,7 @@ static int ddebug_exec_queries(char *query, const char *modname) return nfound; } -/* apply a new bitmap to the sys-knob's current bit-state */ +/* apply a new class-param setting */ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, unsigned long *new_bits, unsigned long *old_bits, const char *query_modname) @@ -606,8 +606,9 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, int matches = 0; int bi, ct; - v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, *old_bits, - query_modname ?: ""); + if (*new_bits != *old_bits) + v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, + *old_bits, query_modname ?: "'*'"); for (bi = 0; bi < map->length; bi++) { if (test_bit(bi, new_bits) == test_bit(bi, old_bits)) @@ -622,8 +623,9 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi, ct, map->class_names[bi], *new_bits); } - v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, *old_bits, - query_modname ?: ""); + if (*new_bits != *old_bits) + v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, + *old_bits, query_modname ?: "'*'"); return matches; }
In ddebug_apply_class_bitmap(), check for actual changes to the bits before announcing them, to declutter logs. no functional change. Signed-off-by: Jim Cromie <jim.cromie@gmail.com> --- lib/dynamic_debug.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)