| Message ID | 20250125064619.8305-2-jim.cromie@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y | expand |
Le 25/01/2025 à 07:45, Jim Cromie a écrit : > commit 47ea6f99d06e ("dyndbg: use ESCAPE_SPACE for cat control") > > changed the control-file to display format strings with "\n" rather > than "\012". Update the docs to match the new reality. > > Signed-off-by: Jim Cromie <jim.cromie@gmail.com> Hi Jim, I think this patch is incomplete, I just tested and the \012 in [1] needs to be replaced too. [1]:https://elixir.bootlin.com/linux/v6.14-rc3/source/Documentation/admin-guide/dynamic-debug-howto.rst#L39-L46 With this change: Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com> Tested-by: Louis Chauvet<louis.chauvet@bootlin.com> > --- > Documentation/admin-guide/dynamic-debug-howto.rst | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst > index 7c036590cd07..691e0f7d4de1 100644 > --- a/Documentation/admin-guide/dynamic-debug-howto.rst > +++ b/Documentation/admin-guide/dynamic-debug-howto.rst > @@ -57,12 +57,12 @@ query/commands to the control file. Example:: > # grease the interface > :#> alias ddcmd='echo $* > /proc/dynamic_debug/control' > > - :#> ddcmd '-p; module main func run* +p' > + :#> ddcmd '-p; module main func run* +p' # disable all, then enable main > :#> grep =p /proc/dynamic_debug/control > - init/main.c:1424 [main]run_init_process =p " with arguments:\012" > - init/main.c:1426 [main]run_init_process =p " %s\012" > - init/main.c:1427 [main]run_init_process =p " with environment:\012" > - init/main.c:1429 [main]run_init_process =p " %s\012" > + init/main.c:1424 [main]run_init_process =p " with arguments:\n" > + init/main.c:1426 [main]run_init_process =p " %s\n" > + init/main.c:1427 [main]run_init_process =p " with environment:\n" > + init/main.c:1429 [main]run_init_process =p " %s\n" > > Error messages go to console/syslog:: >
On Tue, Feb 25, 2025 at 7:30 AM Louis Chauvet <louis.chauvet@bootlin.com> wrote: > > > > Le 25/01/2025 à 07:45, Jim Cromie a écrit : > > commit 47ea6f99d06e ("dyndbg: use ESCAPE_SPACE for cat control") > > > > changed the control-file to display format strings with "\n" rather > > than "\012". Update the docs to match the new reality. > > > > Signed-off-by: Jim Cromie <jim.cromie@gmail.com> > > Hi Jim, > > I think this patch is incomplete, I just tested and the \012 in [1] > needs to be replaced too. > fixed here, thanks.
diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst index 7c036590cd07..691e0f7d4de1 100644 --- a/Documentation/admin-guide/dynamic-debug-howto.rst +++ b/Documentation/admin-guide/dynamic-debug-howto.rst @@ -57,12 +57,12 @@ query/commands to the control file. Example:: # grease the interface :#> alias ddcmd='echo $* > /proc/dynamic_debug/control' - :#> ddcmd '-p; module main func run* +p' + :#> ddcmd '-p; module main func run* +p' # disable all, then enable main :#> grep =p /proc/dynamic_debug/control - init/main.c:1424 [main]run_init_process =p " with arguments:\012" - init/main.c:1426 [main]run_init_process =p " %s\012" - init/main.c:1427 [main]run_init_process =p " with environment:\012" - init/main.c:1429 [main]run_init_process =p " %s\012" + init/main.c:1424 [main]run_init_process =p " with arguments:\n" + init/main.c:1426 [main]run_init_process =p " %s\n" + init/main.c:1427 [main]run_init_process =p " with environment:\n" + init/main.c:1429 [main]run_init_process =p " %s\n" Error messages go to console/syslog::
commit 47ea6f99d06e ("dyndbg: use ESCAPE_SPACE for cat control") changed the control-file to display format strings with "\n" rather than "\012". Update the docs to match the new reality. Signed-off-by: Jim Cromie <jim.cromie@gmail.com> --- Documentation/admin-guide/dynamic-debug-howto.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)