| Message ID | 20250127071059.617567-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/hisilicon/hibmc: select CONFIG_DRM_DISPLAY_DP_HELPER | expand |
On Mon, Jan 27, 2025 at 08:10:02AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Without the DP helper code, the newly added displayport support > causes a link failure: > > x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.o: in function `hibmc_dp_aux_init': > dp_aux.c:(.text+0x37e): undefined reference to `drm_dp_aux_init' > x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function `hibmc_dp_link_set_pattern': > dp_link.c:(.text+0xae): undefined reference to `drm_dp_dpcd_write' > x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function `hibmc_dp_link_get_adjust_train': > dp_link.c:(.text+0x121): undefined reference to `drm_dp_get_adjust_request_voltage' > x86_64-linux-ld: dp_link.c:(.text+0x12e): undefined reference to `drm_dp_get_adjust_request_pre_emphasis' > x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function `hibmc_dp_link_training': > dp_link.c:(.text+0x2b0): undefined reference to `drm_dp_dpcd_write' > x86_64-linux-ld: dp_link.c:(.text+0x2e3): undefined reference to `drm_dp_dpcd_write' > > Add both DRM_DISPLAY_DP_HELPER and DRM_DISPLAY_HELPER, which is > in turn required by the former. > > Fixes: 0ab6ea261c1f ("drm/hisilicon/hibmc: add dp module in hibmc") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >
On Mon, 27 Jan 2025 08:10:02 +0100, Arnd Bergmann wrote: > Without the DP helper code, the newly added displayport support > causes a link failure: > > x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.o: in function `hibmc_dp_aux_init': > dp_aux.c:(.text+0x37e): undefined reference to `drm_dp_aux_init' > x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function `hibmc_dp_link_set_pattern': > dp_link.c:(.text+0xae): undefined reference to `drm_dp_dpcd_write' > x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function `hibmc_dp_link_get_adjust_train': > dp_link.c:(.text+0x121): undefined reference to `drm_dp_get_adjust_request_voltage' > x86_64-linux-ld: dp_link.c:(.text+0x12e): undefined reference to `drm_dp_get_adjust_request_pre_emphasis' > x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function `hibmc_dp_link_training': > dp_link.c:(.text+0x2b0): undefined reference to `drm_dp_dpcd_write' > x86_64-linux-ld: dp_link.c:(.text+0x2e3): undefined reference to `drm_dp_dpcd_write' > > [...] Applied to drm-misc-fixes, thanks! [1/1] drm/hisilicon/hibmc: select CONFIG_DRM_DISPLAY_DP_HELPER commit: 9ab127a18018fb06bd42a54ed38bb7b8c449d686 Best regards,
diff --git a/drivers/gpu/drm/hisilicon/hibmc/Kconfig b/drivers/gpu/drm/hisilicon/hibmc/Kconfig index 93b8d32e3be1..98d77d74999d 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/Kconfig +++ b/drivers/gpu/drm/hisilicon/hibmc/Kconfig @@ -4,6 +4,8 @@ config DRM_HISI_HIBMC depends on DRM && PCI depends on MMU select DRM_CLIENT_SELECTION + select DRM_DISPLAY_HELPER + select DRM_DISPLAY_DP_HELPER select DRM_KMS_HELPER select DRM_VRAM_HELPER select DRM_TTM