| Message ID | 20250204-dw-hdmi-bus-fmt-order-v2-1-d0aaeb7a697a@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/bridge: dw-hdmi: Sync comment block with actual bus formats order | expand |
On 04/02/2025 18:44, Cristian Ciocaltea wrote: > Commit d3d6b1bf85ae ("drm: bridge: dw_hdmi: fix preference of RGB modes > over YUV420") changed the order of the output bus formats, but missed to > update accordingly the "Possible output formats" comment section above > dw_hdmi_bridge_atomic_get_output_bus_fmts(). > > Fix the misleading comment block and a context related typo. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > --- > Changes in v2: > - Reverted the changes related to "Default 8bit RGB fallback" (Neil) > - Updated slightly the commit subject and description > - Link to v1: https://lore.kernel.org/r/20241130-dw-hdmi-bus-fmt-order-v1-1-510b5fb6b990@collabora.com > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 996733ed2c004c83a989cb8da54d8b630d9f2c02..d1256c82de96a43211af64ad70848cd18d5044e5 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -2621,6 +2621,7 @@ static int dw_hdmi_connector_create(struct dw_hdmi *hdmi) > * - MEDIA_BUS_FMT_UYYVYY12_0_5X36, > * - MEDIA_BUS_FMT_UYYVYY10_0_5X30, > * - MEDIA_BUS_FMT_UYYVYY8_0_5X24, > + * - MEDIA_BUS_FMT_RGB888_1X24, > * - MEDIA_BUS_FMT_YUV16_1X48, > * - MEDIA_BUS_FMT_RGB161616_1X48, > * - MEDIA_BUS_FMT_UYVY12_1X24, > @@ -2631,7 +2632,6 @@ static int dw_hdmi_connector_create(struct dw_hdmi *hdmi) > * - MEDIA_BUS_FMT_RGB101010_1X30, > * - MEDIA_BUS_FMT_UYVY8_1X16, > * - MEDIA_BUS_FMT_YUV8_1X24, > - * - MEDIA_BUS_FMT_RGB888_1X24, > */ > > /* Can return a maximum of 11 possible output formats for a mode/connector */ > @@ -2669,7 +2669,7 @@ static u32 *dw_hdmi_bridge_atomic_get_output_bus_fmts(struct drm_bridge *bridge, > } > > /* > - * If the current mode enforces 4:2:0, force the output but format > + * If the current mode enforces 4:2:0, force the output bus format > * to 4:2:0 and do not add the YUV422/444/RGB formats > */ > if (conn->ycbcr_420_allowed && > > --- > base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b > change-id: 20241130-dw-hdmi-bus-fmt-order-7f6db5db2f0a > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 996733ed2c004c83a989cb8da54d8b630d9f2c02..d1256c82de96a43211af64ad70848cd18d5044e5 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -2621,6 +2621,7 @@ static int dw_hdmi_connector_create(struct dw_hdmi *hdmi) * - MEDIA_BUS_FMT_UYYVYY12_0_5X36, * - MEDIA_BUS_FMT_UYYVYY10_0_5X30, * - MEDIA_BUS_FMT_UYYVYY8_0_5X24, + * - MEDIA_BUS_FMT_RGB888_1X24, * - MEDIA_BUS_FMT_YUV16_1X48, * - MEDIA_BUS_FMT_RGB161616_1X48, * - MEDIA_BUS_FMT_UYVY12_1X24, @@ -2631,7 +2632,6 @@ static int dw_hdmi_connector_create(struct dw_hdmi *hdmi) * - MEDIA_BUS_FMT_RGB101010_1X30, * - MEDIA_BUS_FMT_UYVY8_1X16, * - MEDIA_BUS_FMT_YUV8_1X24, - * - MEDIA_BUS_FMT_RGB888_1X24, */ /* Can return a maximum of 11 possible output formats for a mode/connector */ @@ -2669,7 +2669,7 @@ static u32 *dw_hdmi_bridge_atomic_get_output_bus_fmts(struct drm_bridge *bridge, } /* - * If the current mode enforces 4:2:0, force the output but format + * If the current mode enforces 4:2:0, force the output bus format * to 4:2:0 and do not add the YUV422/444/RGB formats */ if (conn->ycbcr_420_allowed &&
Commit d3d6b1bf85ae ("drm: bridge: dw_hdmi: fix preference of RGB modes over YUV420") changed the order of the output bus formats, but missed to update accordingly the "Possible output formats" comment section above dw_hdmi_bridge_atomic_get_output_bus_fmts(). Fix the misleading comment block and a context related typo. Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> --- Changes in v2: - Reverted the changes related to "Default 8bit RGB fallback" (Neil) - Updated slightly the commit subject and description - Link to v1: https://lore.kernel.org/r/20241130-dw-hdmi-bus-fmt-order-v1-1-510b5fb6b990@collabora.com --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b change-id: 20241130-dw-hdmi-bus-fmt-order-7f6db5db2f0a