diff mbox series

[v2,2/3] dt-bindings: display: panel: Add compatible for CSOT PNA957QT1-1

Message ID 20250206131300.1295111-3-yelangyan@huaqin.corp-partner.google.com (mailing list archive)
State New, archived
Headers show
Series support for csot-pna957qt1-1 MIPI-DSI panel | expand

Commit Message

Langyan Ye Feb. 6, 2025, 1:12 p.m. UTC
Add a new compatible for the panel CSOT PNA957QT1-1. This panel uses
HX83102 IC, so add the compatible to the hx83102 binding files.

Signed-off-by: Langyan Ye <yelangyan@huaqin.corp-partner.google.com>
---
 .../devicetree/bindings/display/panel/himax,hx83102.yaml        | 2 ++
 1 file changed, 2 insertions(+)

Comments

Doug Anderson Feb. 6, 2025, 5:17 p.m. UTC | #1
Hi,

On Thu, Feb 6, 2025 at 5:13 AM Langyan Ye
<yelangyan@huaqin.corp-partner.google.com> wrote:
>
> Add a new compatible for the panel CSOT PNA957QT1-1. This panel uses
> HX83102 IC, so add the compatible to the hx83102 binding files.
>
> Signed-off-by: Langyan Ye <yelangyan@huaqin.corp-partner.google.com>
> ---
>  .../devicetree/bindings/display/panel/himax,hx83102.yaml        | 2 ++
>  1 file changed, 2 insertions(+)

I haven't personally run this through DT validation, but this looks
good to me from a visual inspection.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

I would assume this lands through the drm-misc tree and it'll meet up
with the vendor-prefix patch in mainline. That'll cause a temporary
schema validation error in drm-misc but I think that's OK, right? I
also wouldn't personally object to this landing through the DT
bindings tree. As a simple drm-misc committer I'm not sure I have the
official authority to ack that, but I've given my blessing for stuff
like this in the past and haven't been yelled at yet.

For now, I'll wait for a DT maintainer to give it a review and guidance.

-Doug
Conor Dooley Feb. 6, 2025, 6:14 p.m. UTC | #2
On Thu, Feb 06, 2025 at 09:12:59PM +0800, Langyan Ye wrote:
> Add a new compatible for the panel CSOT PNA957QT1-1. This panel uses
> HX83102 IC, so add the compatible to the hx83102 binding files.
> 
> Signed-off-by: Langyan Ye <yelangyan@huaqin.corp-partner.google.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Doug Anderson Feb. 7, 2025, 5:59 p.m. UTC | #3
Hi,

On Thu, Feb 6, 2025 at 10:14 AM Conor Dooley <conor@kernel.org> wrote:
>
> On Thu, Feb 06, 2025 at 09:12:59PM +0800, Langyan Ye wrote:
> > Add a new compatible for the panel CSOT PNA957QT1-1. This panel uses
> > HX83102 IC, so add the compatible to the hx83102 binding files.
> >
> > Signed-off-by: Langyan Ye <yelangyan@huaqin.corp-partner.google.com>
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Pushed to drm-misc-next with Conor's Ack:

[2/3] dt-bindings: display: panel: Add compatible for CSOT PNA957QT1-1
      commit: 36947218ca90c1f560f43c88c438124f8df884d4
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml b/Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml
index c649fb085833..d876269e1fac 100644
--- a/Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml
+++ b/Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml
@@ -18,6 +18,8 @@  properties:
       - enum:
           # Boe nv110wum-l60 11.0" WUXGA TFT LCD panel
           - boe,nv110wum-l60
+          # CSOT pna957qt1-1 10.95" WUXGA TFT LCD panel
+          - csot,pna957qt1-1
           # IVO t109nw41 11.0" WUXGA TFT LCD panel
           - ivo,t109nw41
           # STARRY himax83102-j02 10.51" WUXGA TFT LCD panel