| Message ID | 20250220-fd-mdp4-lvds-v2-4-15afe5578a31@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/msm/mdp4: rework LVDS/LCDC panel support | expand |
On 20.02.2025 12:14 PM, Dmitry Baryshkov wrote: > Instead of using .parent_names, use .parent_data, which binds parent > clocks by using relative names specified in DT rather than using global > system clock names. You're not actually dropping that behavior, since you still populate .name of clock_data. Konrad
On Thu, Feb 20, 2025 at 03:17:23PM +0100, Konrad Dybcio wrote: > On 20.02.2025 12:14 PM, Dmitry Baryshkov wrote: > > Instead of using .parent_names, use .parent_data, which binds parent > > clocks by using relative names specified in DT rather than using global > > system clock names. > > You're not actually dropping that behavior, since you still populate > .name of clock_data. Yeah, it should be "in addition to" > > Konrad
diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c index cbd154c72e44c848fa65fe01d848879b9f6735fb..a99bf482ba2c02e27a76341ae454930a13c8dd92 100644 --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c @@ -122,14 +122,14 @@ static const struct clk_ops mpd4_lvds_pll_ops = { .set_rate = mpd4_lvds_pll_set_rate, }; -static const char *mpd4_lvds_pll_parents[] = { - "pxo", +static const struct clk_parent_data mpd4_lvds_pll_parents[] = { + { .fw_name = "pxo", .name = "pxo", }, }; static struct clk_init_data pll_init = { .name = "mpd4_lvds_pll", .ops = &mpd4_lvds_pll_ops, - .parent_names = mpd4_lvds_pll_parents, + .parent_data = mpd4_lvds_pll_parents, .num_parents = ARRAY_SIZE(mpd4_lvds_pll_parents), };
Instead of using .parent_names, use .parent_data, which binds parent clocks by using relative names specified in DT rather than using global system clock names. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)