| Message ID | 20250225083344.13195-4-clamor95@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm: bridge: add support for Triple 10-BIT | expand |
On Tue, Feb 25, 2025 at 10:33:44AM +0200, Svyatoslav Ryhel wrote: > From: Maxim Schwalm <maxim.schwalm@gmail.com> > > A simple HDMI bridge used in ASUS Transformer AiO P1801-T. > > Signed-off-by: Maxim Schwalm <maxim.schwalm@gmail.com> > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > Reviewed-by: Robert Foss <rfoss@kernel.org> > --- > drivers/gpu/drm/bridge/simple-bridge.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c > index ab0b0e36e97a..c0f1f7baaa37 100644 > --- a/drivers/gpu/drm/bridge/simple-bridge.c > +++ b/drivers/gpu/drm/bridge/simple-bridge.c > @@ -277,6 +277,11 @@ static const struct of_device_id simple_bridge_match[] = { > .timings = &ti_ths8134_bridge_timings, > .connector_type = DRM_MODE_CONNECTOR_VGA, > }, > + }, { > + .compatible = "mstar,tsumu88adt3-lf-1", > + .data = &(const struct simple_bridge_info) { > + .connector_type = DRM_MODE_CONNECTOR_HDMIA, > + }, This entry should also come between adi,adv7123 and ti,opa362. > }, > {}, > }; > -- > 2.43.0 >
вт, 25 лют. 2025 р. о 13:57 Dmitry Baryshkov <dmitry.baryshkov@linaro.org> пише: > > On Tue, Feb 25, 2025 at 10:33:44AM +0200, Svyatoslav Ryhel wrote: > > From: Maxim Schwalm <maxim.schwalm@gmail.com> > > > > A simple HDMI bridge used in ASUS Transformer AiO P1801-T. > > > > Signed-off-by: Maxim Schwalm <maxim.schwalm@gmail.com> > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > > Reviewed-by: Robert Foss <rfoss@kernel.org> > > --- > > drivers/gpu/drm/bridge/simple-bridge.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c > > index ab0b0e36e97a..c0f1f7baaa37 100644 > > --- a/drivers/gpu/drm/bridge/simple-bridge.c > > +++ b/drivers/gpu/drm/bridge/simple-bridge.c > > @@ -277,6 +277,11 @@ static const struct of_device_id simple_bridge_match[] = { > > .timings = &ti_ths8134_bridge_timings, > > .connector_type = DRM_MODE_CONNECTOR_VGA, > > }, > > + }, { > > + .compatible = "mstar,tsumu88adt3-lf-1", > > + .data = &(const struct simple_bridge_info) { > > + .connector_type = DRM_MODE_CONNECTOR_HDMIA, > > + }, > > This entry should also come between adi,adv7123 and ti,opa362. > Original list in the driver is not sorted alphabetically. > > }, > > {}, > > }; > > -- > > 2.43.0 > > > > -- > With best wishes > Dmitry
On Tue, 25 Feb 2025 at 14:02, Svyatoslav Ryhel <clamor95@gmail.com> wrote: > > вт, 25 лют. 2025 р. о 13:57 Dmitry Baryshkov <dmitry.baryshkov@linaro.org> пише: > > > > On Tue, Feb 25, 2025 at 10:33:44AM +0200, Svyatoslav Ryhel wrote: > > > From: Maxim Schwalm <maxim.schwalm@gmail.com> > > > > > > A simple HDMI bridge used in ASUS Transformer AiO P1801-T. > > > > > > Signed-off-by: Maxim Schwalm <maxim.schwalm@gmail.com> > > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > > > Reviewed-by: Robert Foss <rfoss@kernel.org> > > > --- > > > drivers/gpu/drm/bridge/simple-bridge.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c > > > index ab0b0e36e97a..c0f1f7baaa37 100644 > > > --- a/drivers/gpu/drm/bridge/simple-bridge.c > > > +++ b/drivers/gpu/drm/bridge/simple-bridge.c > > > @@ -277,6 +277,11 @@ static const struct of_device_id simple_bridge_match[] = { > > > .timings = &ti_ths8134_bridge_timings, > > > .connector_type = DRM_MODE_CONNECTOR_VGA, > > > }, > > > + }, { > > > + .compatible = "mstar,tsumu88adt3-lf-1", > > > + .data = &(const struct simple_bridge_info) { > > > + .connector_type = DRM_MODE_CONNECTOR_HDMIA, > > > + }, > > > > This entry should also come between adi,adv7123 and ti,opa362. > > > > Original list in the driver is not sorted alphabetically. I'd say, it is, except for the special dumb-vga-dac entry.
diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c index ab0b0e36e97a..c0f1f7baaa37 100644 --- a/drivers/gpu/drm/bridge/simple-bridge.c +++ b/drivers/gpu/drm/bridge/simple-bridge.c @@ -277,6 +277,11 @@ static const struct of_device_id simple_bridge_match[] = { .timings = &ti_ths8134_bridge_timings, .connector_type = DRM_MODE_CONNECTOR_VGA, }, + }, { + .compatible = "mstar,tsumu88adt3-lf-1", + .data = &(const struct simple_bridge_info) { + .connector_type = DRM_MODE_CONNECTOR_HDMIA, + }, }, {}, };