| Message ID | 20250225131332.83415-4-phasta@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] drm/sched: Fix outdated comments referencing thread | expand |
On Tue, Feb 25, 2025 at 02:13:34PM +0100, Philipp Stanner wrote: > The kthread header doesn't need to be included anymore. It's a relict > from the days when the scheduler was still using a kthread instead of > workqueues. > > Remove the unneeded includes. > > Fixes: a6149f039369 ("drm/sched: Convert drm scheduler to use a work queue rather than kthread") > Signed-off-by: Philipp Stanner <phasta@kernel.org> > --- > I'm not sure whether we should Cc the stable kernel. It's inconvenient > and makes build times slower, but isn't really a bug. I don't think that's needed. Analogous to the previous patch of this series, I don't even think it should have a 'Fixes' tag.
diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c index f9811420c787..e55b98af8a50 100644 --- a/drivers/gpu/drm/scheduler/sched_entity.c +++ b/drivers/gpu/drm/scheduler/sched_entity.c @@ -21,7 +21,6 @@ * */ -#include <linux/kthread.h> #include <linux/slab.h> #include <linux/completion.h> diff --git a/drivers/gpu/drm/scheduler/sched_fence.c b/drivers/gpu/drm/scheduler/sched_fence.c index e971528504a5..d6239e015b66 100644 --- a/drivers/gpu/drm/scheduler/sched_fence.c +++ b/drivers/gpu/drm/scheduler/sched_fence.c @@ -21,7 +21,6 @@ * */ -#include <linux/kthread.h> #include <linux/module.h> #include <linux/sched.h> #include <linux/slab.h>
The kthread header doesn't need to be included anymore. It's a relict from the days when the scheduler was still using a kthread instead of workqueues. Remove the unneeded includes. Fixes: a6149f039369 ("drm/sched: Convert drm scheduler to use a work queue rather than kthread") Signed-off-by: Philipp Stanner <phasta@kernel.org> --- I'm not sure whether we should Cc the stable kernel. It's inconvenient and makes build times slower, but isn't really a bug. --- drivers/gpu/drm/scheduler/sched_entity.c | 1 - drivers/gpu/drm/scheduler/sched_fence.c | 1 - 2 files changed, 2 deletions(-)