diff mbox series

[1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity

Message ID 20250225135114.801884-1-alexander.stein@ew.tq-group.com (mailing list archive)
State Accepted
Headers show
Series [1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity | expand

Commit Message

Alexander Stein Feb. 25, 2025, 1:51 p.m. UTC
Polarity for DE is stored in bridge state. Use this flag for setting
the DE polarity in the bridge.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Dmitry Baryshkov Feb. 26, 2025, 6:53 a.m. UTC | #1
On Tue, Feb 25, 2025 at 02:51:13PM +0100, Alexander Stein wrote:
> Polarity for DE is stored in bridge state. Use this flag for setting
> the DE polarity in the bridge.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Herve Codina Feb. 26, 2025, 7:25 a.m. UTC | #2
Hi Alexander,

On Tue, 25 Feb 2025 14:51:13 +0100
Alexander Stein <alexander.stein@ew.tq-group.com> wrote:

> Polarity for DE is stored in bridge state. Use this flag for setting
> the DE polarity in the bridge.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> index 54ad462d17ef7..95563aa1b450d 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> @@ -561,6 +561,8 @@ static void sn65dsi83_atomic_pre_enable(struct drm_bridge *bridge,
>  	       REG_LVDS_FMT_HS_NEG_POLARITY : 0) |
>  	      (mode->flags & DRM_MODE_FLAG_NVSYNC ?
>  	       REG_LVDS_FMT_VS_NEG_POLARITY : 0);
> +	val |= bridge_state->output_bus_cfg.flags & DRM_BUS_FLAG_DE_LOW ?
> +	       REG_LVDS_FMT_DE_NEG_POLARITY : 0;
>  
>  	/* Set up bits-per-pixel, 18bpp or 24bpp. */
>  	if (lvds_format_24bpp) {

Tested without regression on my system.

Tested-by: Herve Codina <herve.codina@bootlin.com>

Best regards,
Hervé
Robert Foss Feb. 26, 2025, 5:39 p.m. UTC | #3
On Tue, 25 Feb 2025 14:51:13 +0100, Alexander Stein wrote:
> Polarity for DE is stored in bridge state. Use this flag for setting
> the DE polarity in the bridge.
> 
> 

Applied, thanks!

[1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity
      (no commit info)



Rob
diff mbox series

Patch

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
index 54ad462d17ef7..95563aa1b450d 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
@@ -561,6 +561,8 @@  static void sn65dsi83_atomic_pre_enable(struct drm_bridge *bridge,
 	       REG_LVDS_FMT_HS_NEG_POLARITY : 0) |
 	      (mode->flags & DRM_MODE_FLAG_NVSYNC ?
 	       REG_LVDS_FMT_VS_NEG_POLARITY : 0);
+	val |= bridge_state->output_bus_cfg.flags & DRM_BUS_FLAG_DE_LOW ?
+	       REG_LVDS_FMT_DE_NEG_POLARITY : 0;
 
 	/* Set up bits-per-pixel, 18bpp or 24bpp. */
 	if (lvds_format_24bpp) {