From patchwork Thu Feb 27 23:16:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ethan Carter Edwards X-Patchwork-Id: 13996286 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B4A4C19776 for ; Fri, 28 Feb 2025 11:42:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C9EB410EC66; Fri, 28 Feb 2025 11:42:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=ethancedwards.com header.i=@ethancedwards.com header.b="h7HpFEDg"; dkim-atps=neutral Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 74AAD10EBB5 for ; Thu, 27 Feb 2025 23:16:55 +0000 (UTC) Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4Z3nKb3F7sz9t8B; Fri, 28 Feb 2025 00:16:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ethancedwards.com; s=MBO0001; t=1740698211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dseSSk06wU9SM6m6oJmDceqrN9+4jBBoifE50IN8BVw=; b=h7HpFEDgPbMibIp9Oa9ArHCLHqiaIT5s9lHkH1hxekL4XWxgljHuH/qQrD+tzJAVyoEYI4 G/YvQjJazTAssJ22hSluaoxhUozLSWxHdWmMlntbpRBmGfwsfSNas9COZsKdh5Dy+dsLwn VCbfnm3PtaDMppLiyaVx/+PYi6YHPfQPuDJSU8MAqbR3BrfLI0PG0bDa7uanZGdAH7Su8s O5zYRc/lWBhzFy27XwFgJW4rgfUYtnFX12tn3OpJgfyjInYLZEn2GmRMHVXHqXdrlGF76o n3jLywXfsE6jYIm0U0ljnl0hB4EEirfe/dzSAd6xHoSiExjbIxDBRxbaEdjWHQ== From: Ethan Carter Edwards Date: Thu, 27 Feb 2025 18:16:23 -0500 Subject: [PATCH 3/4] drm/amd/display: change kzalloc to kcalloc in dcn314_validate_bandwidth() MIME-Version: 1.0 Message-Id: <20250227-amd-display-v1-3-52a060a78d08@ethancedwards.com> References: <20250227-amd-display-v1-0-52a060a78d08@ethancedwards.com> In-Reply-To: <20250227-amd-display-v1-0-52a060a78d08@ethancedwards.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Ethan Carter Edwards X-Developer-Signature: v=1; a=openpgp-sha256; l=1286; i=ethan@ethancedwards.com; h=from:subject:message-id; bh=lhEkQHSHKxxPjFm3cTGvCg+tLSulTLA3kG/2/zxmN6w=; b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0o0bkp2QXk4ekFKWGJEOXFoNThlVGp6e GhQcXlVeHBCLzRGQlNyWVBPNjZlbGFObGVEekpxdCtmVkdBVEsyClBYYnlMNWdYTGxldnpGM1Bk ckNqbElWQmpJdEJWa3lSNVgrT2N0cER6UmtLTy8rNk5NSE1ZV1VDR2NMQXhTa0EKRTlFc1lXUjQ rM2JIQ2hrUGhZS1czMWFyb3F3ayswb2R0OW9kTFdTZitNOUc5NXhEd1A4bmpBdzMyYmZGMkV4Vw ppRzhPK3Bxbjh0cm1PTS9INGxQN1ArKzludlpUOWVwblAyZFdBRXFpUzdjPQo9dzhQQwotLS0tL UVORCBQR1AgTUVTU0FHRS0tLS0tCg== X-Developer-Key: i=ethan@ethancedwards.com; a=openpgp; fpr=2E51F61839D1FA947A7300C234C04305D581DBFE X-Mailman-Approved-At: Fri, 28 Feb 2025 11:42:15 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" We are trying to get rid of all multiplications from allocation functions to prevent integer overflows. Here the multiplication is probably safe, but using kcalloc() is more appropriate and improves readability. This patch has no effect on runtime behavior. Signed-off-by: Ethan Carter Edwards --- drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c index e3ba105034f83434c3e77d343ee267069d34d926..26becc4cb80408cb2778f6af62c7a1c497f06505 100644 --- a/drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c @@ -1704,7 +1704,8 @@ bool dcn314_validate_bandwidth(struct dc *dc, int vlevel = 0; int pipe_cnt = 0; - display_e2e_pipe_params_st *pipes = kzalloc(dc->res_pool->pipe_count * sizeof(display_e2e_pipe_params_st), GFP_KERNEL); + display_e2e_pipe_params_st *pipes = kcalloc(dc->res_pool->pipe_count, + sizeof(display_e2e_pipe_params_st), GFP_KERNEL); DC_LOGGER_INIT(dc->ctx->logger); BW_VAL_TRACE_COUNT();