| Message ID | 20250228-dpu-active-ctl-v2-8-9a9df2ee5193@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/msm/dpu: improve CTL handling on DPU >= 5.0 platforms | expand |
On 28 February 2025 05:14:12 CET, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: >Now as we have dropped the DPU_CTL_SPLIT_DISPLAY from DPU >= 5.0 >configuration, drop the rm->has_legacy_ctl condition which short-cutted >the check for those platforms. > >Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> >Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >--- > >Note, it is imposible to reoder commits in any other sensible way. The Reorder :) >DPU_CTL_SPLIT_DISPLAY can not be dropped before the patch that enables >single-CTL support. Maybe I expected this note on patch 4/6 introducing it, but it disappears after merging anyway so that's a mega-nit. Thanks for sending this! Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> >--- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c >index 4dbc9bc7eb4f151f83055220665ee5fd238ae7ba..2557effe639b5360bc948a49b0cccdb59ee35dab 100644 >--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c >+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c >@@ -410,8 +410,7 @@ static int _dpu_rm_reserve_ctls( > > DPU_DEBUG("ctl %d caps 0x%lX\n", j + CTL_0, features); > >- if (rm->has_legacy_ctls && >- needs_split_display != has_split_display) >+ if (needs_split_display != has_split_display) > continue; > > ctl_idx[i] = j; >
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c index 4dbc9bc7eb4f151f83055220665ee5fd238ae7ba..2557effe639b5360bc948a49b0cccdb59ee35dab 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c @@ -410,8 +410,7 @@ static int _dpu_rm_reserve_ctls( DPU_DEBUG("ctl %d caps 0x%lX\n", j + CTL_0, features); - if (rm->has_legacy_ctls && - needs_split_display != has_split_display) + if (needs_split_display != has_split_display) continue; ctl_idx[i] = j;
Now as we have dropped the DPU_CTL_SPLIT_DISPLAY from DPU >= 5.0 configuration, drop the rm->has_legacy_ctl condition which short-cutted the check for those platforms. Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Note, it is imposible to reoder commits in any other sensible way. The DPU_CTL_SPLIT_DISPLAY can not be dropped before the patch that enables single-CTL support. --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)