From patchwork Sat Mar 1 20:39:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13997683 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71D2CC282D0 for ; Sat, 1 Mar 2025 20:40:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC96310E273; Sat, 1 Mar 2025 20:39:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="VdZHNdxJ"; dkim-atps=neutral Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5284810E2C5 for ; Sat, 1 Mar 2025 20:39:57 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-30797730cbdso31362041fa.3 for ; Sat, 01 Mar 2025 12:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740861596; x=1741466396; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lm0hqPFeMjlAJa0zmvxvNTEk2emtnpzkaRSrh6He2DY=; b=VdZHNdxJ2EczcadhqZhd+Ea5NCA5cpTmgn8084gpXzs5UMgkhZzaaeMDlZNeOTNrX1 p1GL8qlLttPdhuz3OiVD77g9hQbN7BWZFHMfu3d8mKj59MwVMCHnZi51Ne8lLPriz+XD zASz1qbrSEsGRRNu3uzNET0ZmY+MCqb4A9qoC5jlQDztSresE/NYluok12vdgECBxOSk 57p6U90E8cJc0wDDSn2uuEVLYS1rYPmBQiclgnxfVDZU3A6i+x1xzvAevsPl9MWy+/oF Voh3hEZy5A9BPgoj1LqwLOmCJmCjQ47PEH6GO4TrwfADCu7gBpdNG6qWH1BlxVgt+aI6 GTfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740861596; x=1741466396; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lm0hqPFeMjlAJa0zmvxvNTEk2emtnpzkaRSrh6He2DY=; b=WHdpvlAzSKiXCtxXufa6xLwRZDqDlF1tAgQ7MXOHFxP7M/1eZf2AqPCAlWXdejNNAg 8pPvHSJc6YE4yVzeTZvGlKqLDBxtZVV7nFt73/pMHPH2gakqIsoiIOUeOisan9kKUx2H WeziC00OUlnZfrCseNMtELRqxifqSWWV2J1n3iWwfrovIjEvnVF04KyiJNDIbr9FVnuw 0Ix5nWHEEoCLncF66qR/bEvvq5c6M9RCFurI/3gc3PtkQLGJyvfmkC+0c8QNJqEG518O egZp+FD1hTaGo69K4z9ChSJ9EcfZWTxYV40+/cFNFLd3RL9nIXDZaLiVMHuUuayZAZFI JWQQ== X-Gm-Message-State: AOJu0YzhK7vqyBR7whoQNC3NKFOi/XTCVGGjF2zx87/xEICKKNQHUqro Gk76xjvuElqZvcF9hAq4qPASITaSqTq7y64cKa3+hVp0QeUXlK3LmAhQupbi7bk= X-Gm-Gg: ASbGnctCeAPfRjUVQQ1Gh6fEQchaz9J8BXA0vqEw4Uwg4AB1pIa3Q/qJy2xz1Np5FAU rKaPClubyCMAu2Vw8eCJFlGrWsw4rbk3+E2LsPIhWL2SeMtoSPUOpU2g5fsAK85E/CVjHzYIxfP m5/LmY1dLlyscHMZFDjpuEcKWiOAZoceyVceoz+LbzyzNWbvzglI3Lml/9qhNUqhFC0zGB50stI skXXGjgqIM6OO6cdhAVNRh9awXzC31xhma+0y1JaZCSa6WbMHSX4AHy/UuOmsOlKnH8tbR4Uej8 kAP7EPc13ITXkr6f5V24sjkkF0vQQOy9/Lj6jQeUR2RHlOLKiuOo X-Google-Smtp-Source: AGHT+IEmTXK0sA2OkUpupOigZVSjmXwjzqW3fKRIwNjJwyTslP6vQRr4qY7BVPOJdFvgcDcjK+gOIA== X-Received: by 2002:a2e:b896:0:b0:302:1cdd:73c6 with SMTP id 38308e7fff4ca-30b9326af9bmr30502271fa.20.1740861595853; Sat, 01 Mar 2025 12:39:55 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30b931524efsm6668921fa.60.2025.03.01.12.39.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Mar 2025 12:39:54 -0800 (PST) From: Dmitry Baryshkov Date: Sat, 01 Mar 2025 22:39:39 +0200 Subject: [PATCH RFC v2 4/7] drm/display: dp-aux-dev: use new DCPD access helpers MIME-Version: 1.0 Message-Id: <20250301-drm-rework-dpcd-access-v2-4-4d92602fc7cd@linaro.org> References: <20250301-drm-rework-dpcd-access-v2-0-4d92602fc7cd@linaro.org> In-Reply-To: <20250301-drm-rework-dpcd-access-v2-0-4d92602fc7cd@linaro.org> To: Lyude Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Jani Nikula Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Jani Nikula X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1430; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=oiT3XieBMSIfrzEMIa7+tHW3r4Yaol9yvhPjl0hzeR0=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnw3CQKEcLkja2c5fPc4XKGOP4nL47TK+u5bXfS KNn90N+yo2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ8NwkAAKCRCLPIo+Aiko 1UG6CACk3GBifF0q/szx7lNrtLDJrKctDw1YTztUYefU9Y3YIjzg+oBXe4rU31154ET5jAIQEhc vUr+oWgIA+hJOAmPNkXvYWBYhXOBMfO6jpjerRnGOTA3mArW7GX+cc1EckkIb+hVgai/PVo/g7o OAFQBhPJTA/A67N7ugFi/EqD+Irbp4Ya1yt6VKSkwftQLg5UjPDF4HqBDv9cfM3GFAKi19ageVt xGfPppiBwqlSMyq5AFXeuI49x4SSB1fayq9tjEvss07cQfWjtXK6VR7C5eFGXEmKvkA6REGiCra m1aBW/rjjQ/Km0TKrKP2ALBrLsxGnA9DkvZzmBAH4Bo9IJCq X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Switch drm_dp_aux_dev.c to use new set of DPCD read / write helpers. Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_aux_dev.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_aux_dev.c b/drivers/gpu/drm/display/drm_dp_aux_dev.c index 29555b9f03c8c42681c17c4a01e74a966cf8611f..a31ab3f41efb71fd5f936c24ba5c3b8ebea68a5e 100644 --- a/drivers/gpu/drm/display/drm_dp_aux_dev.c +++ b/drivers/gpu/drm/display/drm_dp_aux_dev.c @@ -163,17 +163,16 @@ static ssize_t auxdev_read_iter(struct kiocb *iocb, struct iov_iter *to) break; } - res = drm_dp_dpcd_read(aux_dev->aux, pos, buf, todo); - + res = drm_dp_dpcd_read_data(aux_dev->aux, pos, buf, todo); if (res <= 0) break; - if (copy_to_iter(buf, res, to) != res) { + if (copy_to_iter(buf, todo, to) != todo) { res = -EFAULT; break; } - pos += res; + pos += todo; } if (pos != iocb->ki_pos) @@ -211,12 +210,11 @@ static ssize_t auxdev_write_iter(struct kiocb *iocb, struct iov_iter *from) break; } - res = drm_dp_dpcd_write(aux_dev->aux, pos, buf, todo); - + res = drm_dp_dpcd_write_data(aux_dev->aux, pos, buf, todo); if (res <= 0) break; - pos += res; + pos += todo; } if (pos != iocb->ki_pos)