From patchwork Wed Mar 5 22:59:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lyude Paul X-Patchwork-Id: 14003640 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE462C28B22 for ; Wed, 5 Mar 2025 23:06:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 48DFE10E850; Wed, 5 Mar 2025 23:06:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="BVecKYjU"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id B30D410E84E for ; Wed, 5 Mar 2025 23:06:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741215985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qk/jp+gPRUmslXZDnoYRXtjViDFAYaKs0fIHC124xLM=; b=BVecKYjUPBus3axpyH+JHXnr+g6Qb2AoaT6VNz2jMH+6Qa7caNh3nX93CqiApi+ov3UofA BoWBBr7lMR3L2ymEbUuMd8Rg5+c1gVMbNkObh80Mz9LXlQYY5gjiuSMtRgrdo4tEvkEQEV p6JT+2w+CtfdfFhYDMZdFkO7hi85ZPw= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-547-EFdwfM_IOfOKpD2hnobrBw-1; Wed, 05 Mar 2025 18:06:15 -0500 X-MC-Unique: EFdwfM_IOfOKpD2hnobrBw-1 X-Mimecast-MFC-AGG-ID: EFdwfM_IOfOKpD2hnobrBw_1741215970 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4B2B5180AF58; Wed, 5 Mar 2025 23:06:10 +0000 (UTC) Received: from chopper.redhat.com (unknown [10.22.88.81]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BAD24300019E; Wed, 5 Mar 2025 23:06:05 +0000 (UTC) From: Lyude Paul To: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org Cc: Danilo Krummrich , mcanal@igalia.com, Alice Ryhl , Maxime Ripard , Simona Vetter , Daniel Almeida , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?B?= =?utf-8?q?j=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , linux-kernel@vger.kernel.org (open list) Subject: [RFC v3 11/33] rust: drm/kms: Add ConnectorGuard::set_preferred_mode Date: Wed, 5 Mar 2025 17:59:27 -0500 Message-ID: <20250305230406.567126-12-lyude@redhat.com> In-Reply-To: <20250305230406.567126-1-lyude@redhat.com> References: <20250305230406.567126-1-lyude@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add a wrapper for `drm_set_preferred_mode()` for our new `ConnectorGuard` type so we can set the preferred mode for RVKMS connectors. Signed-off-by: Lyude Paul --- rust/kernel/drm/kms/connector.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/rust/kernel/drm/kms/connector.rs b/rust/kernel/drm/kms/connector.rs index 855a47b189a91..244db1cfdc552 100644 --- a/rust/kernel/drm/kms/connector.rs +++ b/rust/kernel/drm/kms/connector.rs @@ -455,6 +455,12 @@ pub fn add_modes_noedid(&self, (max_h, max_v): (i32, i32)) -> i32 { // SAFETY: We hold the locks required to call this via our type invariants. unsafe { bindings::drm_add_modes_noedid(self.as_raw(), max_h, max_v) } } + + /// Set the preferred display mode for the underlying [`Connector`]. + pub fn set_preferred_mode(&self, (h_pref, w_pref): (i32, i32)) { + // SAFETY: We hold the locks required to call this via our type invariants. + unsafe { bindings::drm_set_preferred_mode(self.as_raw(), h_pref, w_pref) } + } } // SAFETY: DRM expects this struct to be zero-initialized