From patchwork Fri Mar 7 04:34:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 14005927 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1D98C282DE for ; Fri, 7 Mar 2025 04:35:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 270B110E304; Fri, 7 Mar 2025 04:35:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="rFN5W6PY"; dkim-atps=neutral Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E26210E304; Fri, 7 Mar 2025 04:35:23 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C1C39A4547F; Fri, 7 Mar 2025 04:29:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D9A0C4CEEB; Fri, 7 Mar 2025 04:35:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741322122; bh=M5MEdbWeZE7zXQ60oSxYTGxGSrAsMNsHNGf6zM0ZgCw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=rFN5W6PY7nnlg2MfG8mtBZJcZ6Wj4VrpFo3/12tGN+eeZtvxknU9qLl39UW+mHn7e dRg58KZmbCVVXqc32RtsYXILiILuYfxMVM+afA7wxog0belrTQ0mMb0eyxkAPpLHkI FAqQr7sRdjyTHpduyI+6XQLcdjiUPCUNVDD9n2GTwTw/LfJij82aQvuII9XcBKkZQI gBXEP74TCKwMFGUw4vCQjQno8qnbVVclKfZAjFn75V8ymIARs09krw+/F2Bae3F1aI BHNLO1y+ntxX3NVqhMEGLeho0xFqe74FsZhjAjliL+KZ/TBDXAX9UM/yRXBBcnLEvG ZSGETaTAmJvCw== From: Dmitry Baryshkov Date: Fri, 07 Mar 2025 06:34:46 +0200 Subject: [PATCH RFC v3 4/7] drm/display: dp-aux-dev: use new DCPD access helpers MIME-Version: 1.0 Message-Id: <20250307-drm-rework-dpcd-access-v3-4-9044a3a868ee@linaro.org> References: <20250307-drm-rework-dpcd-access-v3-0-9044a3a868ee@linaro.org> In-Reply-To: <20250307-drm-rework-dpcd-access-v3-0-9044a3a868ee@linaro.org> To: Lyude Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Jani Nikula , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Jani Nikula X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1430; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=oiT3XieBMSIfrzEMIa7+tHW3r4Yaol9yvhPjl0hzeR0=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnyndmGiquFLiYR8PUkIV7sx8wYRxkG3NJ/gWei jk4uH0eMKKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ8p3ZgAKCRCLPIo+Aiko 1QsbB/4iThkldo5Tl6AdOyTDiQWFEPSzA0nB/7OSpIBSeO4AazLhMgCVvamyuQiZ+/kb2F9L8Ow 0LDwSYj393Omo3pr0XlCW3kiBlGsxf40hw+Nu6u1rbKVlyHZfJt87GLTgmqiLoS2TKV2Y4fJOoK qMSL/x9LCwN1Xsv8YMw2c9qfKd2QsfCdd77Pl6lkX/Yn2hrxhRtEampbf/DXyOJ4rBHI906MG8Z C7jPVukl4qVteMcihAgdC8iDnps7zu+Wp4fiTORisv9teq83oeBKe6c1KklOJ62FM/wdkzaEaSh QPepK/8E33OqsqCK9WatYMCnoTjfyE3INItaV+yPIKdnoJpI X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Dmitry Baryshkov Switch drm_dp_aux_dev.c to use new set of DPCD read / write helpers. Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_aux_dev.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_aux_dev.c b/drivers/gpu/drm/display/drm_dp_aux_dev.c index 29555b9f03c8c42681c17c4a01e74a966cf8611f..a31ab3f41efb71fd5f936c24ba5c3b8ebea68a5e 100644 --- a/drivers/gpu/drm/display/drm_dp_aux_dev.c +++ b/drivers/gpu/drm/display/drm_dp_aux_dev.c @@ -163,17 +163,16 @@ static ssize_t auxdev_read_iter(struct kiocb *iocb, struct iov_iter *to) break; } - res = drm_dp_dpcd_read(aux_dev->aux, pos, buf, todo); - + res = drm_dp_dpcd_read_data(aux_dev->aux, pos, buf, todo); if (res <= 0) break; - if (copy_to_iter(buf, res, to) != res) { + if (copy_to_iter(buf, todo, to) != todo) { res = -EFAULT; break; } - pos += res; + pos += todo; } if (pos != iocb->ki_pos) @@ -211,12 +210,11 @@ static ssize_t auxdev_write_iter(struct kiocb *iocb, struct iov_iter *from) break; } - res = drm_dp_dpcd_write(aux_dev->aux, pos, buf, todo); - + res = drm_dp_dpcd_write_data(aux_dev->aux, pos, buf, todo); if (res <= 0) break; - pos += res; + pos += todo; } if (pos != iocb->ki_pos)