From patchwork Mon Mar 10 17:18:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Cavitt, Jonathan" X-Patchwork-Id: 14010437 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBCB0C35FF1 for ; Mon, 10 Mar 2025 17:18:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BDDC810E49F; Mon, 10 Mar 2025 17:18:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="RFSIVfxr"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A87610E035; Mon, 10 Mar 2025 17:18:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741627115; x=1773163115; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NBeXvSWAsJ4e7D6fq+XzQgXufZPHcwB28J2XpBnFFR8=; b=RFSIVfxrs3Y5o7RNZvdvX7OgpoeuGJxLnS7Gb6kbTob9zF3y/WvObfNw KO/9thPlPQsrMgT2kw+lQ5+MlXDrHR6dCtcy37vG264m0MTF2kPA7STYV kzS+8qeT4y/iJTqrXQ5awPMqJ5Cw8jTqYxxWrvA/ASbUKWWhBm3O76CEA T1P7TEqj5S5CvlcW6Qo4TUiIIutrqKrvcGhQUvWsAzKrRDg5lPMLuqdtw 4tBdPh/6i3hvkJ5i0VWxI9otamgSWD5PyZFXgxgCub0TuatffYQrLMhDF 945qYWbJA75ov11FWSepOGf+g6I5qp98X61GS2dYKXiEzXrP2Y9ZLdBLz g==; X-CSE-ConnectionGUID: gNc1gmfUTjaILuLkaOa9dQ== X-CSE-MsgGUID: oNHukvsZTuyDhyt5Ofu6TA== X-IronPort-AV: E=McAfee;i="6700,10204,11369"; a="42669299" X-IronPort-AV: E=Sophos;i="6.14,236,1736841600"; d="scan'208";a="42669299" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2025 10:18:35 -0700 X-CSE-ConnectionGUID: OxcHa6tCRZmOB3mnKGsRGQ== X-CSE-MsgGUID: cptud0LPSCSx12cC0OSTVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,236,1736841600"; d="scan'208";a="125097615" Received: from dut4432lnl.fm.intel.com ([10.105.10.85]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2025 10:18:34 -0700 From: Jonathan Cavitt To: intel-xe@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, joonas.lahtinen@linux.intel.com, matthew.brost@intel.com, jianxun.zhang@intel.com, shuicheng.lin@intel.com, dri-devel@lists.freedesktop.org Subject: [PATCH v7 1/6] drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs Date: Mon, 10 Mar 2025 17:18:29 +0000 Message-ID: <20250310171834.78299-2-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250310171834.78299-1-jonathan.cavitt@intel.com> References: <20250310171834.78299-1-jonathan.cavitt@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in handle_pagefault after the VMA lookup. Fixes: 3d420e9fa848 ("drm/xe: Rework GPU page fault handling") Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost --- drivers/gpu/drm/xe/xe_gt_pagefault.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_gt_pagefault.c b/drivers/gpu/drm/xe/xe_gt_pagefault.c index c5ad9a0a89c2..a4e688e72efd 100644 --- a/drivers/gpu/drm/xe/xe_gt_pagefault.c +++ b/drivers/gpu/drm/xe/xe_gt_pagefault.c @@ -237,6 +237,11 @@ static int handle_pagefault(struct xe_gt *gt, struct pagefault *pf) goto unlock_vm; } + if (xe_vma_read_only(vma) && pf->access_type != ACCESS_TYPE_READ) { + err = -EPERM; + goto unlock_vm; + } + atomic = access_is_atomic(pf->access_type); if (xe_vma_is_cpu_addr_mirror(vma))