| Message ID | 20250318080738.29292-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/exynos: exynos7_drm_decon: Consstify struct decon_data | expand |
Hello Krzysztof > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, March 18, 2025 1:38 PM > To: Inki Dae <inki.dae@samsung.com>; Seung-Woo Kim > <sw0312.kim@samsung.com>; Kyungmin Park > <kyungmin.park@samsung.com>; David Airlie <airlied@gmail.com>; Simona > Vetter <simona@ffwll.ch>; Krzysztof Kozlowski <krzk@kernel.org>; Alim > Akhtar <alim.akhtar@samsung.com>; dri-devel@lists.freedesktop.org; linux- > arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- > kernel@vger.kernel.org > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Subject: [PATCH] drm/exynos: exynos7_drm_decon: Consstify struct > decon_data > > static 'struct decon_data' is only read, so it can be const for code safety. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Hi Krzysztof, Merged. Thanks, Inki Dae 2025년 3월 18일 (화) 오후 5:19, Krzysztof Kozlowski < krzysztof.kozlowski@linaro.org>님이 작성: > static 'struct decon_data' is only read, so it can be const for code > safety. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/gpu/drm/exynos/exynos7_drm_decon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c > b/drivers/gpu/drm/exynos/exynos7_drm_decon.c > index 5170f72b0830..f91daefa9d2b 100644 > --- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c > +++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c > @@ -43,13 +43,13 @@ struct decon_data { > unsigned int wincon_burstlen_shift; > }; > > -static struct decon_data exynos7_decon_data = { > +static const struct decon_data exynos7_decon_data = { > .vidw_buf_start_base = 0x80, > .shadowcon_win_protect_shift = 10, > .wincon_burstlen_shift = 11, > }; > > -static struct decon_data exynos7870_decon_data = { > +static const struct decon_data exynos7870_decon_data = { > .vidw_buf_start_base = 0x880, > .shadowcon_win_protect_shift = 8, > .wincon_burstlen_shift = 10, > -- > 2.43.0 > > >
diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/exynos/exynos7_drm_decon.c index 5170f72b0830..f91daefa9d2b 100644 --- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c @@ -43,13 +43,13 @@ struct decon_data { unsigned int wincon_burstlen_shift; }; -static struct decon_data exynos7_decon_data = { +static const struct decon_data exynos7_decon_data = { .vidw_buf_start_base = 0x80, .shadowcon_win_protect_shift = 10, .wincon_burstlen_shift = 11, }; -static struct decon_data exynos7870_decon_data = { +static const struct decon_data exynos7870_decon_data = { .vidw_buf_start_base = 0x880, .shadowcon_win_protect_shift = 8, .wincon_burstlen_shift = 10,
static 'struct decon_data' is only read, so it can be const for code safety. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)