diff mbox series

dma-buf/sw_sync: Fix refcount leak in sw_sync_ioctl_get_deadline

Message ID 20250318152847.30380-1-linmq006@gmail.com (mailing list archive)
State New
Headers show
Series dma-buf/sw_sync: Fix refcount leak in sw_sync_ioctl_get_deadline | expand

Commit Message

Miaoqian Lin March 18, 2025, 3:28 p.m. UTC
Fix reference count leak in by adding dma_fence_put() when
dma_fence_to_sync_pt() fails after the call to sync_file_get_fence().

Fixes: 70e67aaec2f4 ("dma-buf/sw_sync: Add fence deadline support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/dma-buf/sw_sync.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/dma-buf/sw_sync.c b/drivers/dma-buf/sw_sync.c
index f5905d67dedb..b7615c5c6cac 100644
--- a/drivers/dma-buf/sw_sync.c
+++ b/drivers/dma-buf/sw_sync.c
@@ -438,8 +438,10 @@  static int sw_sync_ioctl_get_deadline(struct sync_timeline *obj, unsigned long a
 		return -EINVAL;
 
 	pt = dma_fence_to_sync_pt(fence);
-	if (!pt)
+	if (!pt) {
+		dma_fence_put(fence);
 		return -EINVAL;
+	}
 
 	spin_lock_irqsave(fence->lock, flags);
 	if (test_bit(SW_SYNC_HAS_DEADLINE_BIT, &fence->flags)) {