From patchwork Thu Mar 20 16:00:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 14024123 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C5E0C35FFF for ; Thu, 20 Mar 2025 16:00:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CFA2210E66C; Thu, 20 Mar 2025 16:00:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="R75OKkUe"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id B809210E668 for ; Thu, 20 Mar 2025 16:00:47 +0000 (UTC) Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F5B5743; Thu, 20 Mar 2025 16:59:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1742486343; bh=IIDKgphBR8Z+MRb90fam19Jh4edh+nhVkDzVKuQW/rY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=R75OKkUe3S77fCRa7Hyf99JE7idmz1QLo7ZW9JJo6ugI5ZVDcxjm/dNxRYTOVq0aT FKrAmClKfJ6473OXrhsBEe4MN8NcxcZVtc1LaZl//2CS57x+UT0hSDjsjw+/st1XmE ab0npDQ0fU1yIYJELJMqY2oRyPobV0w45mumYPK8= From: Tomi Valkeinen Date: Thu, 20 Mar 2025 18:00:09 +0200 Subject: [PATCH 14/18] drm/bridge: cdns-dsi: Use videomode internally MIME-Version: 1.0 Message-Id: <20250320-cdns-dsi-impro-v1-14-725277c5f43b@ideasonboard.com> References: <20250320-cdns-dsi-impro-v1-0-725277c5f43b@ideasonboard.com> In-Reply-To: <20250320-cdns-dsi-impro-v1-0-725277c5f43b@ideasonboard.com> To: Jyri Sarha , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Vinod Koul , Kishon Vijay Abraham I , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Francesco Dolcini , Aradhya Bhatia , Devarsh Thakkar , Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=4546; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=IIDKgphBR8Z+MRb90fam19Jh4edh+nhVkDzVKuQW/rY=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBn3DubPPPYYZaMHel9AvP+DlscBUhPpOifEIBnD Vxi7kUq+Z6JAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZ9w7mwAKCRD6PaqMvJYe 9ZIqEACYYzWG+QcesEgv9AUYi0HpUHRDv2CAPUovtA6UnSoKk09kmF5tZW5AR+P7gjK+HbUz6Hk 1ZJFaNR1brKDLWsjJgMgeeireYnr4IF9ZDJ7TT1hkQUyBaiQDGeKiieW1AVOWqi3h3PWagg+pok ovh2XgMO6QW4XfmpkNecU8O/zgbXWwE3BwIvtKdyYu6K/1XEdiE3YV8PabnZf+k4Ko5iBE87qel FpHzE5GAtSvh21+hItb4obn3RjcbSTfJ5ArQLUBz9mn4OkoqPeE4v1uhFCwSY5Z23Q86Lnp+DRx 4FTt29ozUJQPPxqfl72bIjc3KV8zoOfleCusA/cf/1TAXGavwu4EgNUygzsoA2cPOWDVBtDRiTg 5um7dlRLo72DIQVGDsnr1CVyvE4slw7E+fotSBbi9S2xSlyn30t32UGKpUyyJSqMQKlTFecqqF5 QNK1rL2bPLJDdaQdebm5+pi1CpFFgwpkeHS1F0Ybn+EV/u847qrAgZLWwRxxyenwqL6MGxCvOhU E5VyCJD7AEN3YM/r+0QsOXKhr/8XA25tOquELWZ9AoT1d07S5E1TnXHySkIdJKSMUKB1/Du+SBB 16K+LolUVA6HICshUL+w0Y3z39ELAHe72hm49FhRX9SwZE4DJcaZks4brG6ZiqhzeE2WTiax53E IeRZ/vYg7EWUA6A== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The drm_display_mode is a bit difficult one to use (we need hfp, hbp, ... instead of hsync_start, hsync_end, ...) and understand (when to use crtc_* fields). To simplify the code, use struct videomode internally which cleans up the code. If in the future we want to use crtc_* fields in some code patchs, that can be easily achieved by creating a videomode from the crtc_* fields, and no change to the functions that do the work is needed. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 31 +++++++++++++++----------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c index 220213f5cb09..1a30e2f7d402 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c @@ -9,6 +9,7 @@ #include #include #include