From patchwork Thu Mar 20 09:57:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre-Eric Pelloux-Prayer X-Patchwork-Id: 14023639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED044C28B30 for ; Thu, 20 Mar 2025 09:59:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 55EEC10E5BC; Thu, 20 Mar 2025 09:59:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="rUR1oJOO"; dkim-atps=neutral Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2044.outbound.protection.outlook.com [40.107.92.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3AB3510E5BB for ; Thu, 20 Mar 2025 09:59:36 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rPLTPODMo5f/OmWqWBc80dtN/MRknc5knCYkO3qmgNzreXw5BEomCY5BOFmnyiE39XRqvS2Uw+QQ91yNueA8rhljh4i9FPTTyhtqkWHS0xMotvqJGmibIy7UXGRBnZ2dZ0q5d6tdzxLPW7Spt/t7wmGZZD8DGL1eSH2JtFNVwhCo8zWL/kHuyb7QOI2TJPOro8K5unLxQPT5ArU4tR42ShzXmUHn5WuuqjE7mCSckg5liJDCfI378qsaOUSOpLeNLuZCHq1KucwSCYIzpnbMVZQnaBEe31sx8C1gxXmYoKaktl+HQ0Y4iW5XVh9sUKrN3Gp5qdwB2qtZ9qviYjkV1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IXrQTGTzheUF28f7gC2QFrZZOiro9ryAFKLgAhOHx6s=; b=q3NDR3F4KdoO+LaEqTSOl1v+Ex3Zr2ct0SaKPkZTyxP2dJP1ahpkYDdDdfkgaHMpSGE6EipctEtEsFxPzMJf5xoJaJ/pXYA7MkfTjtf7oAEYT+B6EIBawRwaYqqc0ezKTrPDT5GXZaAG+6JgL2+jbjT/99jOMKD2mtsjxyQAAYZm8KMMtd0+MswzkxBq5/cKb4VDUoTT/pkpAzzD0XH/sXwjR9IrEI6aVy9aCQ6V08ktVB/vnHeqx0mcj2F6c1Z59JDmfNE0FL+CK0PEZg2eju67lHtRiWSawt1DAed797+xOB8MyPtLPwERyXDUmCQSyvUJKo6DxAYwal93XSmpIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IXrQTGTzheUF28f7gC2QFrZZOiro9ryAFKLgAhOHx6s=; b=rUR1oJOOeD45okCOhVTq6qiFb71rv+g3y4RIyUMM6F280jYJDww1J3ioTsCeEEfxgvLqCIWhrlCpX5e27qDguNqz6U3tCVabHQ3o9AEyilj+BBD5wbqFdXzt7W9HVRqivcsdnkpip2EhHtCKA77osKE6CMWd5RUC14NyFAE45PY= Received: from IA1P220CA0014.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:464::8) by DS0PR12MB6656.namprd12.prod.outlook.com (2603:10b6:8:d2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.34; Thu, 20 Mar 2025 09:59:28 +0000 Received: from BL02EPF0001A0FE.namprd03.prod.outlook.com (2603:10b6:208:464:cafe::8e) by IA1P220CA0014.outlook.office365.com (2603:10b6:208:464::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8534.34 via Frontend Transport; Thu, 20 Mar 2025 09:59:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0001A0FE.mail.protection.outlook.com (10.167.242.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8534.20 via Frontend Transport; Thu, 20 Mar 2025 09:59:27 +0000 Received: from FRAPPELLOUX01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 20 Mar 2025 04:59:26 -0500 From: Pierre-Eric Pelloux-Prayer To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: Pierre-Eric Pelloux-Prayer , =?utf-8?q?Christian_K=C3=B6nig?= , , Subject: [PATCH v8 01/10] drm/debugfs: output client_id in in drm_clients_info Date: Thu, 20 Mar 2025 10:57:57 +0100 Message-ID: <20250320095818.40622-2-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250320095818.40622-1-pierre-eric.pelloux-prayer@amd.com> References: <20250320095818.40622-1-pierre-eric.pelloux-prayer@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A0FE:EE_|DS0PR12MB6656:EE_ X-MS-Office365-Filtering-Correlation-Id: 48ce15b1-b03f-4884-2c01-08dd6795e6fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?q?Nws3FX4esonmewM4PjRTlrWTAXZlCoi?= =?utf-8?q?bxE1onMAVCZeQsV+b7x9BeUIRXHhBe9iiGgJBHtPNiOgI/MPTUIBA7TNjXJi6B1mx?= =?utf-8?q?W20pcVQ8ZZ0+VaM/hEt5LLt8c8UDdxNCPMzms1dmys4Zpjh//ebj/XX+ukT3ouw3J?= =?utf-8?q?ipIs6Wq0bTVYdYfgPZ4dK5cOuDNvsnqrA96MX+f57E8MOw2IECxz26dobqLnrhZhj?= =?utf-8?q?aNaLx0IBcQpWMiQ6n8U5tBdi+xJqP21y5kVn+eVjMN1s1lUPcbSp7ATf6+I1kMnXc?= =?utf-8?q?FQ2nYfGI/Dz4OdTgaPPzWsf0Y+6GZLrfyVLZIxoWgS1UYJF/TNcCfnd+G5njTEpJl?= =?utf-8?q?7EQFJrfzaDbcYG5tWBocOAb86jRxd+mgaUqCIEP2+4oYZRVsxZalu6OKZWSIflgAM?= =?utf-8?q?J4awXVxUnwi0zuf0c+PvJ4Osr8kh/vTcvlPPvXa56/NtQH3Tluepi5Vb5gOLiwOnS?= =?utf-8?q?c6XbLicyd1AqWtaJjBpHCsumLNUoG1/E2tM5htmJb4uWxSpzPEgzhIr5uT5vS+q4e?= =?utf-8?q?zLGl4AAK8QvAE2Oda/zXxu/Rf5C1StsMf5S60m1OI1eM4Oy+ZvswBXND9IKZIFRhA?= =?utf-8?q?i2lXV0wwXMfqXfW0HBb/4kdMR0RPjLTm8AoqUfL/lGOEWFw2KRoGHN4Dg8D3svBP/?= =?utf-8?q?jyorW9Zz+kiamQHmYt2+tuhUWnzA/Bz4xLykXwR1j6R1m+4Uixs47QiGA0hqr6fgr?= =?utf-8?q?JE5ZPsg6UrmSGnizD1Ktu2I11mvEAT1ar3qy+pyzPs3+dwfb3QBWgftOlH2mhRUKZ?= =?utf-8?q?RYroEP3tXFPof/GvVFTRGssQrykCFuQ2T93eSA/gzGwxfU7lyL4WRhPEOjsNH5T7C?= =?utf-8?q?v5ghZ4nbu7TPwQZKpcQMQ9ZGZ9NvP/VjsWudfnWmbdH8gdzxAeHatSJft2SqMW7dv?= =?utf-8?q?MsujejGSmVLmWl+Pr7Q6niCFSieH8x7omfiwB+p39cfBoaxgcRpoqB2M7DLwB0aua?= =?utf-8?q?YG/fbjiqIDDB+Rnyz1tR+Y5bRNs8ZaapXDtDXqQtfCWegK3xvhNjFRdagHVQ0RLXv?= =?utf-8?q?ULBFXuyEQPR8toTlO0TpN6H3fJvdeb+vXcMTp3kZFVJQSGP3RDbx3jlO7e1Vpg8RP?= =?utf-8?q?kg2Kg0UfyKoMHbWosVdeibWB/Yvslr+Jxaar5egqsZlwSUaABxdaH+D5RRqIGX6RU?= =?utf-8?q?SA26FfoUqK5j0zd8A7hpqdqIhh7VXi0+U9KcJgY9dV3bOmOcjdiHWvNb2+n5G1XuO?= =?utf-8?q?vK1hFZoVxORuyNGV8pTILvtHGWFtm7ASvaf0c9PThLHy0l7zKx0KsGTL81p+wnoev?= =?utf-8?q?wAw2zd0RuZbIxiIrvcA4iSLMMZPwpxhX+ZVBlBJTgOjZ5TXaS1PbAk/uIYHuOvQOm?= =?utf-8?q?xDDaAIaJDLfxHxfOKY8Bkn92bzCNsumzXFXixAsShVaZRul3IBBGsGyO1DBiwH6Aj?= =?utf-8?q?iu+Q7xHIN6xbiL8E+SO9igKlsiNDf2uQn3iJCI7Pe6kHy3wzimvLdA=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2025 09:59:27.9239 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48ce15b1-b03f-4884-2c01-08dd6795e6fc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A0FE.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6656 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" client_id is a unique id used by fdinfo. Having it listed in 'clients' output means a userspace application can correlate the fields, eg: given a fdinfo id get the fdinfo name. Geiven that client_id is a uint64_t, we use a %20llu printf format to keep the output aligned (20 = digit count of the biggest uint64_t). Reviewed-by: Christian König Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/drm_debugfs.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index 6b2178864c7e..aed51c8883fd 100644 --- a/drivers/gpu/drm/drm_debugfs.c +++ b/drivers/gpu/drm/drm_debugfs.c @@ -77,14 +77,15 @@ static int drm_clients_info(struct seq_file *m, void *data) kuid_t uid; seq_printf(m, - "%20s %5s %3s master a %5s %10s %*s\n", + "%20s %5s %3s master a %5s %10s %*s %20s\n", "command", "tgid", "dev", "uid", "magic", DRM_CLIENT_NAME_MAX_LEN, - "name"); + "name", + "id"); /* dev->filelist is sorted youngest first, but we want to present * oldest first (i.e. kernel, servers, clients), so walk backwardss. @@ -100,7 +101,7 @@ static int drm_clients_info(struct seq_file *m, void *data) pid = rcu_dereference(priv->pid); task = pid_task(pid, PIDTYPE_TGID); uid = task ? __task_cred(task)->euid : GLOBAL_ROOT_UID; - seq_printf(m, "%20s %5d %3d %c %c %5d %10u %*s\n", + seq_printf(m, "%20s %5d %3d %c %c %5d %10u %*s %20llu\n", task ? task->comm : "", pid_vnr(pid), priv->minor->index, @@ -109,7 +110,8 @@ static int drm_clients_info(struct seq_file *m, void *data) from_kuid_munged(seq_user_ns(m), uid), priv->magic, DRM_CLIENT_NAME_MAX_LEN, - priv->client_name ? priv->client_name : ""); + priv->client_name ? priv->client_name : "", + priv->client_id); rcu_read_unlock(); mutex_unlock(&priv->client_name_lock); }