| Message ID | 20250320185238.447458-45-jim.cromie@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y | expand |
Le 20/03/2025 à 19:52, Jim Cromie a écrit : > Invoke DRM_CLASSMAP_USE from xe_drm_client.c. When built with > CONFIG_DRM_USE_DYNAMIC_DEBUG=y, this tells dydnbg that Xe uses > has drm.debug calls. > > Signed-off-by: Jim Cromie <jim.cromie@gmail.com> > --- > drivers/gpu/drm/xe/xe_drm_client.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/xe/xe_drm_client.c b/drivers/gpu/drm/xe/xe_drm_client.c > index 2d4874d2b922..756dba5c88f8 100644 > --- a/drivers/gpu/drm/xe/xe_drm_client.c > +++ b/drivers/gpu/drm/xe/xe_drm_client.c > @@ -21,6 +21,8 @@ > #include "xe_pm.h" > #include "xe_trace.h" > > +DRM_CLASSMAP_USE(drm_debug_classes); > + Is xe_drm_client.c the best place to do it? I think the module entry point is a bit better [1]. [1]:https://elixir.bootlin.com/linux/v6.13.7/source/drivers/gpu/drm/xe/xe_module.c > /** > * DOC: DRM Client usage stats > *
On Mon, Mar 24, 2025 at 9:24 AM Louis Chauvet <louis.chauvet@bootlin.com> wrote: > > > > Le 20/03/2025 à 19:52, Jim Cromie a écrit : > > Invoke DRM_CLASSMAP_USE from xe_drm_client.c. When built with > > CONFIG_DRM_USE_DYNAMIC_DEBUG=y, this tells dydnbg that Xe uses > > has drm.debug calls. > > > > Signed-off-by: Jim Cromie <jim.cromie@gmail.com> > > --- > > drivers/gpu/drm/xe/xe_drm_client.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/xe/xe_drm_client.c b/drivers/gpu/drm/xe/xe_drm_client.c > > index 2d4874d2b922..756dba5c88f8 100644 > > --- a/drivers/gpu/drm/xe/xe_drm_client.c > > +++ b/drivers/gpu/drm/xe/xe_drm_client.c > > @@ -21,6 +21,8 @@ > > #include "xe_pm.h" > > #include "xe_trace.h" > > > > +DRM_CLASSMAP_USE(drm_debug_classes); > > + > > Is xe_drm_client.c the best place to do it? I think the module entry > point is a bit better [1]. > yes perhaps. I was drawn by the _client in the file-name. Im not sure Im fully consistent, iirc the drivers get it near driver-iinit ops. > [1]:https://elixir.bootlin.com/linux/v6.13.7/source/drivers/gpu/drm/xe/xe_module.c > > > /** > > * DOC: DRM Client usage stats > > * > > -- > Louis Chauvet, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > >
diff --git a/drivers/gpu/drm/xe/xe_drm_client.c b/drivers/gpu/drm/xe/xe_drm_client.c index 2d4874d2b922..756dba5c88f8 100644 --- a/drivers/gpu/drm/xe/xe_drm_client.c +++ b/drivers/gpu/drm/xe/xe_drm_client.c @@ -21,6 +21,8 @@ #include "xe_pm.h" #include "xe_trace.h" +DRM_CLASSMAP_USE(drm_debug_classes); + /** * DOC: DRM Client usage stats *
Invoke DRM_CLASSMAP_USE from xe_drm_client.c. When built with CONFIG_DRM_USE_DYNAMIC_DEBUG=y, this tells dydnbg that Xe uses has drm.debug calls. Signed-off-by: Jim Cromie <jim.cromie@gmail.com> --- drivers/gpu/drm/xe/xe_drm_client.c | 2 ++ 1 file changed, 2 insertions(+)