From patchwork Mon Mar 24 18:57:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ariel D'Alessandro X-Patchwork-Id: 14027717 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DD65C3600C for ; Mon, 24 Mar 2025 18:59:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E84910E4C2; Mon, 24 Mar 2025 18:59:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=ariel.dalessandro@collabora.com header.b="cO64ugO4"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBF1F10E4C1 for ; Mon, 24 Mar 2025 18:59:47 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1742842774; cv=none; d=zohomail.com; s=zohoarc; b=BoRCzjIFldMuc/a6uQYiOIj7Xq0iufNoMKCQy6ROpdVtA0j3FvwdKakmFs8YDxrHf+ZNRE85aGajqD5JNtM/sFs2vYvqBgDer3EXQxnTbnOazzZhU0F+Q/w727ix/0PmdRusSinG3VMkvB+xEsF2Gv59/LWtxH6NGVJ96FeOTW8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742842774; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=PFJTcCbD3E4H+S0hUP75IrBoIFbNnQ/Q1nSq47W+r74=; b=AYn+WRlOuiS7a94agR3+2K+wevmdLx0WmfuWfMcvKGr7oXQWwcZWtatT1GP/TlrxAUwX7A7E0GjiGfvFCDGOPprgN/s2/tZxu18WOCUR0Zdu2kwy3lc1SgpqzzQ7q0cmhweMKgHLzSppP+PwqqdjNSm2u8ocyWHY4PFdVIfa0Xg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=ariel.dalessandro@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1742842774; s=zohomail; d=collabora.com; i=ariel.dalessandro@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=PFJTcCbD3E4H+S0hUP75IrBoIFbNnQ/Q1nSq47W+r74=; b=cO64ugO4k+sOjIvBPdT8DKBuljGkeTVquQ3GymHIGGOAxbt5FXQbf4LccdzONZPz BuTexm4izpqMhEIRCYlbsPmZkUl3o6eUwGNV9EIi3I7zG9JmnAUxQtgInHB5ug0KAcm OiX8LO5kfjQWFAqpDO7N61cbYPTfQaJBYR942r04= Received: by mx.zohomail.com with SMTPS id 1742842771637557.8226679941961; Mon, 24 Mar 2025 11:59:31 -0700 (PDT) From: Ariel D'Alessandro To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: boris.brezillon@collabora.com, robh@kernel.org, steven.price@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, kernel@collabora.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, sjoerd@collabora.com, angelogioacchino.delregno@collabora.com, Ariel D'Alessandro , =?utf-8?q?Adri=C3=A1n?= =?utf-8?q?_Larumbe?= Subject: [PATCH v5 1/6] drm/panfrost: Set IOMMU_CACHE flag Date: Mon, 24 Mar 2025 15:57:56 -0300 Message-ID: <20250324185801.168664-2-ariel.dalessandro@collabora.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250324185801.168664-1-ariel.dalessandro@collabora.com> References: <20250324185801.168664-1-ariel.dalessandro@collabora.com> MIME-Version: 1.0 X-ZohoMailClient: External X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Panfrost does not support uncached mappings, so flag them properly. Also flag the pages that are mapped as response to a page fault as cached. Signed-off-by: Boris Brezillon Signed-off-by: Ariel D'Alessandro Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price Reviewed-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c index b91019cd5acb..9e6f198ef5c1 100644 --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c @@ -327,7 +327,7 @@ int panfrost_mmu_map(struct panfrost_gem_mapping *mapping) struct drm_gem_object *obj = &shmem->base; struct panfrost_device *pfdev = to_panfrost_device(obj->dev); struct sg_table *sgt; - int prot = IOMMU_READ | IOMMU_WRITE; + int prot = IOMMU_READ | IOMMU_WRITE | IOMMU_CACHE; if (WARN_ON(mapping->active)) return 0; @@ -528,7 +528,7 @@ static int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as, goto err_map; mmu_map_sg(pfdev, bomapping->mmu, addr, - IOMMU_WRITE | IOMMU_READ | IOMMU_NOEXEC, sgt); + IOMMU_WRITE | IOMMU_READ | IOMMU_CACHE | IOMMU_NOEXEC, sgt); bomapping->active = true; bo->heap_rss_size += SZ_2M;