| Message ID | 20250324210359.1199574-3-ojeda@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [01/10] drm/panic: add missing space | expand |
On 24/03/2025 22:03, Miguel Ojeda wrote: > Add missing Markdown code span. > > This was found using the Clippy `doc_markdown` lint, which we may want > to enable. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> You want to take the whole series in the rust tree? Otherwise I can push the patch 1-2 to drm-misc-next if needed.
On Tue, Mar 25, 2025 at 10:05 AM Jocelyn Falempe <jfalempe@redhat.com> wrote: > > Thanks, it looks good to me. > > Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> > > You want to take the whole series in the rust tree? > > Otherwise I can push the patch 1-2 to drm-misc-next if needed. Please take them if possible, since others may want to take them through their tree anyway, plus it should have less conflicts if you change other bits, plus these are independent fixes anyway that can go in on their own whether or not the lint gets eventually enabled. Thanks! Cheers, Miguel
On 25/03/2025 20:04, Miguel Ojeda wrote: > On Tue, Mar 25, 2025 at 10:05 AM Jocelyn Falempe <jfalempe@redhat.com> wrote: >> >> Thanks, it looks good to me. >> >> Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> >> >> You want to take the whole series in the rust tree? >> >> Otherwise I can push the patch 1-2 to drm-misc-next if needed. > > Please take them if possible, since others may want to take them > through their tree anyway, plus it should have less conflicts if you > change other bits, plus these are independent fixes anyway that can go > in on their own whether or not the lint gets eventually enabled. I just pushed 1-2 to drm-misc-next Thanks,
diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs index 9bd4d131f033..a8f832598c70 100644 --- a/drivers/gpu/drm/drm_panic_qr.rs +++ b/drivers/gpu/drm/drm_panic_qr.rs @@ -914,7 +914,7 @@ fn draw_all(&mut self, data: impl Iterator<Item = u8>) { /// will be encoded as binary segment, otherwise it will be encoded /// efficiently as a numeric segment, and appended to the URL. /// * `data_len`: Length of the data, that needs to be encoded, must be less -/// than data_size. +/// than `data_size`. /// * `data_size`: Size of data buffer, it should be at least 4071 bytes to hold /// a V40 QR code. It will then be overwritten with the QR code image. /// * `tmp`: A temporary buffer that the QR code encoder will use, to write the
Add missing Markdown code span. This was found using the Clippy `doc_markdown` lint, which we may want to enable. Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen") Signed-off-by: Miguel Ojeda <ojeda@kernel.org> --- drivers/gpu/drm/drm_panic_qr.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)