| Message ID | 20250324210824.3094660-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/i2c: tda998x: select CONFIG_DRM_KMS_HELPER | expand |
On 24/03/2025 22:08, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > This fails to build without the KMS helper functions: > > x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o: in function `tda998x_detect_work': > tda998x_drv.c:(.text+0x4e6): undefined reference to `drm_kms_helper_hotplug_event' > x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o: in function `tda998x_bind': > tda998x_drv.c:(.text.unlikely+0x33): undefined reference to `drm_simple_encoder_init' > x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o:(.rodata+0x584): undefined reference to `drm_atomic_helper_connector_reset' > x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o:(.rodata+0x590): undefined reference to `drm_helper_probe_single_connector_modes' > x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o:(.rodata+0x5a4): undefined reference to `drm_atomic_helper_connector_duplicate_state' > x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o:(.rodata+0x5a8): undefined reference to `drm_atomic_helper_connector_destroy_state' > > Select the missing symbol and fix up the broken whitespace. > > Fixes: 325ba852d148 ("drm/i2c: move TDA998x driver under drivers/gpu/drm/bridge") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/gpu/drm/bridge/Kconfig | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index d20f1646dac2..09a1be234f71 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -91,12 +91,13 @@ config DRM_FSL_LDB > Support for i.MX8MP DPI-to-LVDS on-SoC encoder. > > config DRM_I2C_NXP_TDA998X > - tristate "NXP Semiconductors TDA998X HDMI encoder" > - default m if DRM_TILCDC > - select CEC_CORE if CEC_NOTIFIER > - select SND_SOC_HDMI_CODEC if SND_SOC > - help > - Support for NXP Semiconductors TDA998X HDMI encoders. > + tristate "NXP Semiconductors TDA998X HDMI encoder" > + default m if DRM_TILCDC > + select CEC_CORE if CEC_NOTIFIER > + select DRM_KMS_HELPER > + select SND_SOC_HDMI_CODEC if SND_SOC > + help > + Support for NXP Semiconductors TDA998X HDMI encoders. > > config DRM_ITE_IT6263 > tristate "ITE IT6263 LVDS/HDMI bridge" Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On Mon, 24 Mar 2025 22:08:07 +0100, Arnd Bergmann wrote: > This fails to build without the KMS helper functions: > > x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o: in function `tda998x_detect_work': > tda998x_drv.c:(.text+0x4e6): undefined reference to `drm_kms_helper_hotplug_event' > x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o: in function `tda998x_bind': > tda998x_drv.c:(.text.unlikely+0x33): undefined reference to `drm_simple_encoder_init' > x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o:(.rodata+0x584): undefined reference to `drm_atomic_helper_connector_reset' > x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o:(.rodata+0x590): undefined reference to `drm_helper_probe_single_connector_modes' > x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o:(.rodata+0x5a4): undefined reference to `drm_atomic_helper_connector_duplicate_state' > x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o:(.rodata+0x5a8): undefined reference to `drm_atomic_helper_connector_destroy_state' > > [...] Applied to drm-misc-next-fixes, thanks! [1/1] drm/i2c: tda998x: select CONFIG_DRM_KMS_HELPER commit: 85a063b8b281e144ed96463936fb4e6b3d4fe9e4 Best regards,
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index d20f1646dac2..09a1be234f71 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -91,12 +91,13 @@ config DRM_FSL_LDB Support for i.MX8MP DPI-to-LVDS on-SoC encoder. config DRM_I2C_NXP_TDA998X - tristate "NXP Semiconductors TDA998X HDMI encoder" - default m if DRM_TILCDC - select CEC_CORE if CEC_NOTIFIER - select SND_SOC_HDMI_CODEC if SND_SOC - help - Support for NXP Semiconductors TDA998X HDMI encoders. + tristate "NXP Semiconductors TDA998X HDMI encoder" + default m if DRM_TILCDC + select CEC_CORE if CEC_NOTIFIER + select DRM_KMS_HELPER + select SND_SOC_HDMI_CODEC if SND_SOC + help + Support for NXP Semiconductors TDA998X HDMI encoders. config DRM_ITE_IT6263 tristate "ITE IT6263 LVDS/HDMI bridge"