| Message ID | 20250325-b4-panel-refcounting-v1-5-4e2bf5d19c5d@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/panel: Panel Refcounting infrastructure | expand |
On Tue, 25 Mar 2025 13:24:12 -0400 Anusha Srivatsa <asrivats@redhat.com> wrote: > Start using the new helper that does the refcounted > allocations. > > Signed-off-by: Anusha Srivatsa <asrivats@redhat.com> > --- > drivers/gpu/drm/panel/panel-simple.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 6ba600f97aa4c8daae577823fcf17ef31b0eb46f..60b845fad4e1b378af52d34dfae0139c4625dc51 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -579,7 +579,8 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > u32 bus_flags; > int err; > > - panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL); > + panel = devm_drm_panel_alloc(dev, struct panel_simple, base, > + &panel_simple_funcs, desc->connector_type); > if (!panel) > return -ENOMEM; devm_drm_panel_alloc() returns "Pointer to new panel, or ERR_PTR on failure.", so you need IS_ERR() to check for an error condition: if (IS_ERR(panel)) return PTR_ERR(Panel); Otherwise looks good. Luca
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 6ba600f97aa4c8daae577823fcf17ef31b0eb46f..60b845fad4e1b378af52d34dfae0139c4625dc51 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -579,7 +579,8 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) u32 bus_flags; int err; - panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL); + panel = devm_drm_panel_alloc(dev, struct panel_simple, base, + &panel_simple_funcs, desc->connector_type); if (!panel) return -ENOMEM; @@ -694,8 +695,6 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) pm_runtime_set_autosuspend_delay(dev, 1000); pm_runtime_use_autosuspend(dev); - drm_panel_init(&panel->base, dev, &panel_simple_funcs, connector_type); - err = drm_panel_of_backlight(&panel->base); if (err) { dev_err_probe(dev, err, "Could not find backlight\n");
Start using the new helper that does the refcounted allocations. Signed-off-by: Anusha Srivatsa <asrivats@redhat.com> --- drivers/gpu/drm/panel/panel-simple.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)