| Message ID | 20250325155756.703907-2-sanyapilot496@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add Visionox G2647FB105 panel support | expand |
On 3/25/25 19:35, Krzysztof Kozlowski wrote: > On 25/03/2025 16:57, Alexander Baransky wrote: >> The Visionox G2647FB105 is a 6.47 inch 1080x2340 MIPI-DSI CMD mode > > "Add a DT binding for the Visionox....." > >> AMOLED panel used in: >> - Xiaomi Mi Note 10 / CC9 Pro (sm7150-xiaomi-tucana) >> - Xiaomi Mi Note 10 Lite (sm7150-xiaomi-toco) >> >> Add a dt-binding for it. > And drop this sentence. > >> Signed-off-by: Alexander Baransky<sanyapilot496@gmail.com> >> --- > > ... > >> +properties: >> + compatible: >> + const: visionox,g2647fb105 >> + >> + reg: >> + maxItems: 1 >> + >> + vdd3p3-supply: >> + description: 3.3V source voltage rail >> + >> + vddio-supply: >> + description: I/O source voltage rail >> + >> + vsn-supply: >> + description: Negative source voltage rail >> + >> + vsp-supply: >> + description: Positive source voltage rail > Are you sure these are real voltage rails on the device? Weirdly similar > to some old Samsung AMOLED panels... Hello Krzysztof, I was somewhat intrigued by your observation, especially since I have some schematics for this device. The patch correctly adds four regulators – ibb, lab, vdd (3p0), and vio (1p8). This situation arises from Xiaomi’s tendency to use different panels in various revisions of the same device. Although, AFAIK, the sm7150-xiaomi-toco/tucana was released with only one possible variation (which this series adds), the sm7150-xiaomi-davinci offers a different perspective. The latter was initially produced with a samsung,ams639rq08 panel (which I had added previously), yet official service centers have replaced the factory panel with the visionox,g1639fp106 during repairs. This suggests that, in terms of power configuration, the samsung,ams639rq08 and the visionox,g1639fp106 panels are effectively identical. It is therefore likely that the visionox,g2647fb105 from this series follows the same way. Nevertheless, it is reassuring that I can confirm these findings with the schematics rather than relying on mere guesswork xD --- Best wishes Danila > Best regards, > Krzysztof
On 25/03/2025 19:16, Danila Tikhonov wrote: >>> + vsp-supply: >>> + description: Positive source voltage rail >> Are you sure these are real voltage rails on the device? Weirdly similar >> to some old Samsung AMOLED panels... > Hello Krzysztof, > > I was somewhat intrigued by your observation, especially since I have > some schematics for this device. The patch correctly adds four > regulators – ibb, lab, vdd (3p0), and vio (1p8). > > This situation arises from Xiaomi’s tendency to use different panels in > various revisions of the same device. Although, AFAIK, the > sm7150-xiaomi-toco/tucana was released with only one possible variation > (which this series adds), the sm7150-xiaomi-davinci offers a different > perspective. The latter was initially produced with a samsung,ams639rq08 > panel (which I had added previously), yet official service centers have > replaced the factory panel with the visionox,g1639fp106 during repairs. > This suggests that, in terms of power configuration, the > samsung,ams639rq08 and the visionox,g1639fp106 panels are effectively > identical. > > It is therefore likely that the visionox,g2647fb105 from this series > follows the same way. > > Nevertheless, it is reassuring that I can confirm these findings with > the schematics rather than relying on mere guesswork xD Great, appreciated, thanks for checking. Some parts of above - similarities including replacement of factory panel - might be good for commit msg. Please add them. With that and simplifying the commit sentence style: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/panel/visionox,g2647fb105.yaml b/Documentation/devicetree/bindings/display/panel/visionox,g2647fb105.yaml new file mode 100644 index 000000000000..49dcd9b8f670 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/visionox,g2647fb105.yaml @@ -0,0 +1,79 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/visionox,g2647fb105.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Visionox G2647FB105 6.47" 1080x2340 MIPI-DSI Panel + +maintainers: + - Alexander Baransky <sanyapilot496@gmail.com> + +description: + The Visionox G2647FB105 is a 6.47 inch 1080x2340 MIPI-DSI CMD mode OLED panel. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: visionox,g2647fb105 + + reg: + maxItems: 1 + + vdd3p3-supply: + description: 3.3V source voltage rail + + vddio-supply: + description: I/O source voltage rail + + vsn-supply: + description: Negative source voltage rail + + vsp-supply: + description: Positive source voltage rail + + reset-gpios: true + port: true + +required: + - compatible + - reg + - vdd3p3-supply + - vddio-supply + - vsn-supply + - vsp-supply + - reset-gpios + - port + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + dsi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "visionox,g2647fb105"; + reg = <0>; + + vdd3p3-supply = <&vreg_l7c_3p0>; + vddio-supply = <&vreg_l13a_1p8>; + vsn-supply = <&vreg_ibb>; + vsp-supply = <&vreg_lab>; + + reset-gpios = <&pm6150l_gpios 9 GPIO_ACTIVE_LOW>; + + port { + panel_in: endpoint { + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + }; + }; + +...
The Visionox G2647FB105 is a 6.47 inch 1080x2340 MIPI-DSI CMD mode AMOLED panel used in: - Xiaomi Mi Note 10 / CC9 Pro (sm7150-xiaomi-tucana) - Xiaomi Mi Note 10 Lite (sm7150-xiaomi-toco) Add a dt-binding for it. Signed-off-by: Alexander Baransky <sanyapilot496@gmail.com> --- .../display/panel/visionox,g2647fb105.yaml | 79 +++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/visionox,g2647fb105.yaml