| Message ID | 20250325212823.669459-3-lyude@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm: Make some resolution info unsigned | expand |
Hi Am 25.03.25 um 22:27 schrieb Lyude Paul: > Similarly, it doesn't really make much sense for us to allow devices to > specify their minimum/maximum resolution as signed. So, let's fix that as > well while we're at it. This commit message only makes sense in the context of the series. Better remove 'Similarily' and 'as well while we're at it'. > > Signed-off-by: Lyude Paul <lyude@redhat.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Maxime Ripard <mripard@kernel.org> > --- > include/drm/drm_mode_config.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > index 271765e2e9f2d..4b8f0370b79bf 100644 > --- a/include/drm/drm_mode_config.h > +++ b/include/drm/drm_mode_config.h > @@ -532,8 +532,8 @@ struct drm_mode_config { > */ > struct list_head privobj_list; > > - int min_width, min_height; > - int max_width, max_height; > + unsigned int min_width, min_height; > + unsigned int max_width, max_height; No problem, I just hope this has no fallout where these fields are being used. Best regards Thomas > const struct drm_mode_config_funcs *funcs; > > /* output poll support */
diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h index 271765e2e9f2d..4b8f0370b79bf 100644 --- a/include/drm/drm_mode_config.h +++ b/include/drm/drm_mode_config.h @@ -532,8 +532,8 @@ struct drm_mode_config { */ struct list_head privobj_list; - int min_width, min_height; - int max_width, max_height; + unsigned int min_width, min_height; + unsigned int max_width, max_height; const struct drm_mode_config_funcs *funcs; /* output poll support */
Similarly, it doesn't really make much sense for us to allow devices to specify their minimum/maximum resolution as signed. So, let's fix that as well while we're at it. Signed-off-by: Lyude Paul <lyude@redhat.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Maxime Ripard <mripard@kernel.org> --- include/drm/drm_mode_config.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)