| Message ID | 20250327-b4-panel-refcounting-v2-4-b5f5ca551f95@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/panel: Panel Refcounting infrastructure | expand |
On Thu, 27 Mar 2025 10:55:42 -0400, Anusha Srivatsa wrote: > Start using the new helper that does the refcounted > allocations. > > v2: check error condition (Luca) > > > [ ... ] Reviewed-by: Maxime Ripard <mripard@kernel.org> Thanks! Maxime
On Thu, 27 Mar 2025 10:55:42 -0400 Anusha Srivatsa <asrivats@redhat.com> wrote: > Start using the new helper that does the refcounted > allocations. > > v2: check error condition (Luca) Here as well, when you resend, move the changelog after the '---' line. > Signed-off-by: Anusha Srivatsa <asrivats@redhat.com> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
On Fri, Mar 28, 2025 at 4:54 AM Luca Ceresoli <luca.ceresoli@bootlin.com> wrote: > On Thu, 27 Mar 2025 10:55:42 -0400 > Anusha Srivatsa <asrivats@redhat.com> wrote: > > > Start using the new helper that does the refcounted > > allocations. > > > > v2: check error condition (Luca) > > Here as well, when you resend, move the changelog after the '---' line. > > Hadn't noticed this. Saw some other series that do follow this method. I will make this change. Anusha > > Signed-off-by: Anusha Srivatsa <asrivats@redhat.com> > > Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > > -- > Luca Ceresoli, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > >
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 6ba600f97aa4c8daae577823fcf17ef31b0eb46f..df718c4a86cb7dc0cd126e807d33306e5a21d8a0 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -579,9 +579,10 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) u32 bus_flags; int err; - panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL); - if (!panel) - return -ENOMEM; + panel = devm_drm_panel_alloc(dev, struct panel_simple, base, + &panel_simple_funcs, desc->connector_type); + if (IS_ERR(panel)) + return PTR_ERR(panel); panel->desc = desc; @@ -694,8 +695,6 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) pm_runtime_set_autosuspend_delay(dev, 1000); pm_runtime_use_autosuspend(dev); - drm_panel_init(&panel->base, dev, &panel_simple_funcs, connector_type); - err = drm_panel_of_backlight(&panel->base); if (err) { dev_err_probe(dev, err, "Could not find backlight\n");
Start using the new helper that does the refcounted allocations. v2: check error condition (Luca) Signed-off-by: Anusha Srivatsa <asrivats@redhat.com> --- drivers/gpu/drm/panel/panel-simple.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)