| Message ID | 20250327104300.1982058-1-boris.brezillon@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] accel/ivpu: pages_use_count is now a refcount_t | expand |
On 3/27/25 13:42, Boris Brezillon wrote: > Commit 051b6646d36d ("drm/shmem-helper: Use refcount_t for > pages_use_count") changed the type of > drm_gem_shmem_object::pages_use_count but accel drivers were left > behind. > > Fixes: 051b6646d36d ("drm/shmem-helper: Use refcount_t for pages_use_count") > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com> > Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> > Cc: Maciej Falkowski <maciej.falkowski@linux.intel.com> > Cc: Oded Gabbay <ogabbay@kernel.org> > Cc: dri-devel@lists.freedesktop.org > --- > drivers/accel/ivpu/ivpu_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c > index 8741c73b92ce..09c9c5256af5 100644 > --- a/drivers/accel/ivpu/ivpu_gem.c > +++ b/drivers/accel/ivpu/ivpu_gem.c > @@ -282,7 +282,7 @@ static void ivpu_gem_bo_free(struct drm_gem_object *obj) > ivpu_bo_unbind_locked(bo); > mutex_destroy(&bo->lock); > > - drm_WARN_ON(obj->dev, bo->base.pages_use_count > 1); > + drm_WARN_ON(obj->dev, refcount_read(&bo->base.pages_use_count) > 1); > drm_gem_shmem_free(&bo->base); > } > Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
On Thu, 27 Mar 2025, Boris Brezillon <boris.brezillon@collabora.com> wrote: > Commit 051b6646d36d ("drm/shmem-helper: Use refcount_t for > pages_use_count") changed the type of > drm_gem_shmem_object::pages_use_count but accel drivers were left > behind. > > Fixes: 051b6646d36d ("drm/shmem-helper: Use refcount_t for pages_use_count") > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com> > Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> > Cc: Maciej Falkowski <maciej.falkowski@linux.intel.com> > Cc: Oded Gabbay <ogabbay@kernel.org> > Cc: dri-devel@lists.freedesktop.org Just for build, on the series, Tested-by: Jani Nikula <jani.nikula@intel.com> Please merge. > --- > drivers/accel/ivpu/ivpu_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c > index 8741c73b92ce..09c9c5256af5 100644 > --- a/drivers/accel/ivpu/ivpu_gem.c > +++ b/drivers/accel/ivpu/ivpu_gem.c > @@ -282,7 +282,7 @@ static void ivpu_gem_bo_free(struct drm_gem_object *obj) > ivpu_bo_unbind_locked(bo); > mutex_destroy(&bo->lock); > > - drm_WARN_ON(obj->dev, bo->base.pages_use_count > 1); > + drm_WARN_ON(obj->dev, refcount_read(&bo->base.pages_use_count) > 1); > drm_gem_shmem_free(&bo->base); > }
On 3/27/25 14:30, Jani Nikula wrote: > On Thu, 27 Mar 2025, Boris Brezillon <boris.brezillon@collabora.com> wrote: >> Commit 051b6646d36d ("drm/shmem-helper: Use refcount_t for >> pages_use_count") changed the type of >> drm_gem_shmem_object::pages_use_count but accel drivers were left >> behind. >> >> Fixes: 051b6646d36d ("drm/shmem-helper: Use refcount_t for pages_use_count") >> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> >> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com> >> Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> >> Cc: Maciej Falkowski <maciej.falkowski@linux.intel.com> >> Cc: Oded Gabbay <ogabbay@kernel.org> >> Cc: dri-devel@lists.freedesktop.org > > Just for build, on the series, > > Tested-by: Jani Nikula <jani.nikula@intel.com> > > Please merge. Applied to misc-next
Hi, On 3/27/2025 12:37 PM, Dmitry Osipenko wrote: > On 3/27/25 14:30, Jani Nikula wrote: >> On Thu, 27 Mar 2025, Boris Brezillon <boris.brezillon@collabora.com> wrote: >>> Commit 051b6646d36d ("drm/shmem-helper: Use refcount_t for >>> pages_use_count") changed the type of >>> drm_gem_shmem_object::pages_use_count but accel drivers were left >>> behind. >>> >>> Fixes: 051b6646d36d ("drm/shmem-helper: Use refcount_t for pages_use_count") >>> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> >>> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com> >>> Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> >>> Cc: Maciej Falkowski <maciej.falkowski@linux.intel.com> >>> Cc: Oded Gabbay <ogabbay@kernel.org> >>> Cc: dri-devel@lists.freedesktop.org >> >> Just for build, on the series, >> >> Tested-by: Jani Nikula <jani.nikula@intel.com> >> >> Please merge. > > Applied to misc-next This was applied in less then an hour after posting for review without any testing (building is not testing). I can't see how this is up to community standards. I would prefer that patches for accel/ivpu were merged by ivpu maintainers. At least give us time to review them. Regards, Jacek
On Thu, 27 Mar 2025, Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> wrote: > Hi, > > On 3/27/2025 12:37 PM, Dmitry Osipenko wrote: >> On 3/27/25 14:30, Jani Nikula wrote: >>> On Thu, 27 Mar 2025, Boris Brezillon <boris.brezillon@collabora.com> wrote: >>>> Commit 051b6646d36d ("drm/shmem-helper: Use refcount_t for >>>> pages_use_count") changed the type of >>>> drm_gem_shmem_object::pages_use_count but accel drivers were left >>>> behind. >>>> >>>> Fixes: 051b6646d36d ("drm/shmem-helper: Use refcount_t for pages_use_count") >>>> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> >>>> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com> >>>> Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> >>>> Cc: Maciej Falkowski <maciej.falkowski@linux.intel.com> >>>> Cc: Oded Gabbay <ogabbay@kernel.org> >>>> Cc: dri-devel@lists.freedesktop.org >>> >>> Just for build, on the series, >>> >>> Tested-by: Jani Nikula <jani.nikula@intel.com> >>> >>> Please merge. >> >> Applied to misc-next > > This was applied in less then an hour after posting for review without any testing (building is not testing). > I can't see how this is up to community standards. > I would prefer that patches for accel/ivpu were merged by ivpu maintainers. > At least give us time to review them. I regret rushing Boris/Dmitry to merge. Sorry about that. My only excuse is that the build was broken, and the changes were small and mechanical, similar to what was done elsewhere to change the interfaces. BR, Jani.
On 3/27/25 15:19, Jacek Lawrynowicz wrote: > Hi, > > On 3/27/2025 12:37 PM, Dmitry Osipenko wrote: >> On 3/27/25 14:30, Jani Nikula wrote: >>> On Thu, 27 Mar 2025, Boris Brezillon <boris.brezillon@collabora.com> wrote: >>>> Commit 051b6646d36d ("drm/shmem-helper: Use refcount_t for >>>> pages_use_count") changed the type of >>>> drm_gem_shmem_object::pages_use_count but accel drivers were left >>>> behind. >>>> >>>> Fixes: 051b6646d36d ("drm/shmem-helper: Use refcount_t for pages_use_count") >>>> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> >>>> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com> >>>> Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> >>>> Cc: Maciej Falkowski <maciej.falkowski@linux.intel.com> >>>> Cc: Oded Gabbay <ogabbay@kernel.org> >>>> Cc: dri-devel@lists.freedesktop.org >>> >>> Just for build, on the series, >>> >>> Tested-by: Jani Nikula <jani.nikula@intel.com> >>> >>> Please merge. >> >> Applied to misc-next > > This was applied in less then an hour after posting for review without any testing (building is not testing). > I can't see how this is up to community standards. > I would prefer that patches for accel/ivpu were merged by ivpu maintainers. > At least give us time to review them. Not the first time I'm forgetting about accle/, my bad. Maybe you could add yourself as a reviewer to drm-shmem MAINTAINERS to not miss relevant DRM code changes in future.
Hi, On 3/27/2025 1:32 PM, Jani Nikula wrote: > On Thu, 27 Mar 2025, Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> wrote: >> Hi, >> >> On 3/27/2025 12:37 PM, Dmitry Osipenko wrote: >>> On 3/27/25 14:30, Jani Nikula wrote: >>>> On Thu, 27 Mar 2025, Boris Brezillon <boris.brezillon@collabora.com> wrote: >>>>> Commit 051b6646d36d ("drm/shmem-helper: Use refcount_t for >>>>> pages_use_count") changed the type of >>>>> drm_gem_shmem_object::pages_use_count but accel drivers were left >>>>> behind. >>>>> >>>>> Fixes: 051b6646d36d ("drm/shmem-helper: Use refcount_t for pages_use_count") >>>>> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> >>>>> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com> >>>>> Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> >>>>> Cc: Maciej Falkowski <maciej.falkowski@linux.intel.com> >>>>> Cc: Oded Gabbay <ogabbay@kernel.org> >>>>> Cc: dri-devel@lists.freedesktop.org >>>> >>>> Just for build, on the series, >>>> >>>> Tested-by: Jani Nikula <jani.nikula@intel.com> >>>> >>>> Please merge. >>> >>> Applied to misc-next >> >> This was applied in less then an hour after posting for review without any testing (building is not testing). >> I can't see how this is up to community standards. >> I would prefer that patches for accel/ivpu were merged by ivpu maintainers. >> At least give us time to review them. > > I regret rushing Boris/Dmitry to merge. Sorry about that. > > My only excuse is that the build was broken, and the changes were small > and mechanical, similar to what was done elsewhere to change the > interfaces. I guess it OK as this doesn't happen too often and I would probably do the same :) Regards, Jacek
diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c index 8741c73b92ce..09c9c5256af5 100644 --- a/drivers/accel/ivpu/ivpu_gem.c +++ b/drivers/accel/ivpu/ivpu_gem.c @@ -282,7 +282,7 @@ static void ivpu_gem_bo_free(struct drm_gem_object *obj) ivpu_bo_unbind_locked(bo); mutex_destroy(&bo->lock); - drm_WARN_ON(obj->dev, bo->base.pages_use_count > 1); + drm_WARN_ON(obj->dev, refcount_read(&bo->base.pages_use_count) > 1); drm_gem_shmem_free(&bo->base); }
Commit 051b6646d36d ("drm/shmem-helper: Use refcount_t for pages_use_count") changed the type of drm_gem_shmem_object::pages_use_count but accel drivers were left behind. Fixes: 051b6646d36d ("drm/shmem-helper: Use refcount_t for pages_use_count") Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com> Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> Cc: Maciej Falkowski <maciej.falkowski@linux.intel.com> Cc: Oded Gabbay <ogabbay@kernel.org> Cc: dri-devel@lists.freedesktop.org --- drivers/accel/ivpu/ivpu_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)