| Message ID | 20250327104300.1982058-3-boris.brezillon@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] accel/ivpu: pages_use_count is now a refcount_t | expand |
On 3/27/25 13:43, Boris Brezillon wrote: > Commit 8f5c4871a014 ("drm/gem: Change locked/unlocked postfix of > drm_gem_v/unmap() function names") dropped the _unlocked suffix, > but accel drivers were left behind. > > Fixes: 8f5c4871a014 ("drm/gem: Change locked/unlocked postfix of drm_gem_v/unmap() function names") > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com> > Cc: Min Ma <min.ma@amd.com> > Cc: Lizhi Hou <lizhi.hou@amd.com> > Cc: Oded Gabbay <ogabbay@kernel.org> > Cc: dri-devel@lists.freedesktop.org > --- > drivers/accel/amdxdna/amdxdna_gem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/accel/amdxdna/amdxdna_gem.c b/drivers/accel/amdxdna/amdxdna_gem.c > index 606433d73236..d9691dca12d1 100644 > --- a/drivers/accel/amdxdna/amdxdna_gem.c > +++ b/drivers/accel/amdxdna/amdxdna_gem.c > @@ -81,7 +81,7 @@ static void amdxdna_gem_obj_free(struct drm_gem_object *gobj) > if (abo->type == AMDXDNA_BO_DEV_HEAP) > drm_mm_takedown(&abo->mm); > > - drm_gem_vunmap_unlocked(gobj, &map); > + drm_gem_vunmap(gobj, &map); > mutex_destroy(&abo->lock); > drm_gem_shmem_free(&abo->base); > } > @@ -417,7 +417,7 @@ amdxdna_drm_create_cmd_bo(struct drm_device *dev, > abo->type = AMDXDNA_BO_CMD; > abo->client = filp->driver_priv; > > - ret = drm_gem_vmap_unlocked(to_gobj(abo), &map); > + ret = drm_gem_vmap(to_gobj(abo), &map); > if (ret) { > XDNA_ERR(xdna, "Vmap cmd bo failed, ret %d", ret); > goto release_obj; Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
diff --git a/drivers/accel/amdxdna/amdxdna_gem.c b/drivers/accel/amdxdna/amdxdna_gem.c index 606433d73236..d9691dca12d1 100644 --- a/drivers/accel/amdxdna/amdxdna_gem.c +++ b/drivers/accel/amdxdna/amdxdna_gem.c @@ -81,7 +81,7 @@ static void amdxdna_gem_obj_free(struct drm_gem_object *gobj) if (abo->type == AMDXDNA_BO_DEV_HEAP) drm_mm_takedown(&abo->mm); - drm_gem_vunmap_unlocked(gobj, &map); + drm_gem_vunmap(gobj, &map); mutex_destroy(&abo->lock); drm_gem_shmem_free(&abo->base); } @@ -417,7 +417,7 @@ amdxdna_drm_create_cmd_bo(struct drm_device *dev, abo->type = AMDXDNA_BO_CMD; abo->client = filp->driver_priv; - ret = drm_gem_vmap_unlocked(to_gobj(abo), &map); + ret = drm_gem_vmap(to_gobj(abo), &map); if (ret) { XDNA_ERR(xdna, "Vmap cmd bo failed, ret %d", ret); goto release_obj;
Commit 8f5c4871a014 ("drm/gem: Change locked/unlocked postfix of drm_gem_v/unmap() function names") dropped the _unlocked suffix, but accel drivers were left behind. Fixes: 8f5c4871a014 ("drm/gem: Change locked/unlocked postfix of drm_gem_v/unmap() function names") Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com> Cc: Min Ma <min.ma@amd.com> Cc: Lizhi Hou <lizhi.hou@amd.com> Cc: Oded Gabbay <ogabbay@kernel.org> Cc: dri-devel@lists.freedesktop.org --- drivers/accel/amdxdna/amdxdna_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)