From patchwork Thu Mar 27 16:01:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vignesh Raman X-Patchwork-Id: 14031261 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E2CDC3600B for ; Thu, 27 Mar 2025 16:01:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C8B310E91A; Thu, 27 Mar 2025 16:01:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="CFmtlTR3"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 54FA910E914 for ; Thu, 27 Mar 2025 16:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1743091304; bh=7Qk2WD3HGqrUJbtVGplfJG8We98IqG6UMJa28Cvw1Zw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CFmtlTR3gtVI+lTDEOGcw60CY0xcsn6/CczUPBjEFGKdJICLVZ2qj1hc5bgy59W9d CGtked7fQCGfwaVzTWhGc//zJz1Tj2SQjV8WAUNKVjUfl9VcsXbPLax7kqnDAKX7Qm SJA2Gdal7EnowXxmviBnVNbSgpxlM1kJ6lbIfGKUBzuHRHKmr+GNuqtvkKT1rCvBw1 MHe3k9jfh4cxVUscrdwZMze/YSQbDqS/HfbID3x4t2OlvUN7aY2LLDvmqIqM+qyCtl dTc3O5CMKisQwuXcRtvSkmB3FS1v/TbroJ8I5cjwjT+FBZta9j2C2A2Q6jU/eNGkKf yn4ZJQ2jIb+3Q== Received: from debian.. (unknown [171.76.87.92]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: vignesh) by bali.collaboradmins.com (Postfix) with ESMTPSA id 697FA17E0FDB; Thu, 27 Mar 2025 17:01:40 +0100 (CET) From: Vignesh Raman To: dri-devel@lists.freedesktop.org Cc: daniels@collabora.com, helen.fornazier@gmail.com, airlied@gmail.com, simona.vetter@ffwll.ch, robdclark@gmail.com, guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com, valentine.burley@collabora.com, lumag@kernel.org, quic_abhinavk@quicinc.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/3] drm/ci: Add jobs to validate devicetrees Date: Thu, 27 Mar 2025 21:31:11 +0530 Message-ID: <20250327160117.945165-3-vignesh.raman@collabora.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250327160117.945165-1-vignesh.raman@collabora.com> References: <20250327160117.945165-1-vignesh.raman@collabora.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add jobs to run dt_binding_check and dtbs_check. If warnings are seen, exit with a non-zero error code while configuring them as warning in the GitLab CI pipeline. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/check-devicetrees.yml | 38 ++++++++++++++++++++++ drivers/gpu/drm/ci/dt-binding-check.sh | 18 +++++++++++ drivers/gpu/drm/ci/dtbs-check.sh | 41 ++++++++++++++++++++++++ drivers/gpu/drm/ci/gitlab-ci.yml | 1 + 4 files changed, 98 insertions(+) create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh diff --git a/drivers/gpu/drm/ci/check-devicetrees.yml b/drivers/gpu/drm/ci/check-devicetrees.yml new file mode 100644 index 000000000000..5f0c477f7578 --- /dev/null +++ b/drivers/gpu/drm/ci/check-devicetrees.yml @@ -0,0 +1,38 @@ +.dt-check-base: + timeout: "1h" + variables: + FF_USE_NEW_BASH_EVAL_STRATEGY: 'true' + script: + - drivers/gpu/drm/ci/${SCRIPT_NAME} + artifacts: + when: on_failure + paths: + - ${ARTIFACT_FILE} + allow_failure: + exit_codes: + - 102 + +dtbs-check:arm32: + extends: + - .build:arm32 + - .dt-check-base + variables: + SCRIPT_NAME: "dtbs-check.sh" + ARTIFACT_FILE: "dtbs-check.log" + +dtbs-check:arm64: + extends: + - .build:arm64 + - .dt-check-base + variables: + SCRIPT_NAME: "dtbs-check.sh" + ARTIFACT_FILE: "dtbs-check.log" + +dt-binding-check: + extends: + - .build + - .use-debian/x86_64_build + - .dt-check-base + variables: + SCRIPT_NAME: "dt-binding-check.sh" + ARTIFACT_FILE: "dt-binding-check.log" diff --git a/drivers/gpu/drm/ci/dt-binding-check.sh b/drivers/gpu/drm/ci/dt-binding-check.sh new file mode 100755 index 000000000000..2a72bb89c013 --- /dev/null +++ b/drivers/gpu/drm/ci/dt-binding-check.sh @@ -0,0 +1,18 @@ +#!/bin/bash +# SPDX-License-Identifier: MIT + +set -euxo pipefail + +apt-get update -qq +apt install -y --no-install-recommends yamllint +pip3 install dtschema + +if ! make -j${FDO_CI_CONCURRENT:-4} dt_binding_check >/dev/null 2>dt-binding-check.log; then + echo "ERROR: 'make dt_binding_check' failed. Please check dt-binding-check.log for details." + exit 1 +fi + +if [[ -s dt-binding-check.log ]]; then + echo "WARNING: dt_binding_check reported warnings. Please check dt-binding-check.log for details." + exit 102 +fi diff --git a/drivers/gpu/drm/ci/dtbs-check.sh b/drivers/gpu/drm/ci/dtbs-check.sh new file mode 100755 index 000000000000..a0129d5a53b0 --- /dev/null +++ b/drivers/gpu/drm/ci/dtbs-check.sh @@ -0,0 +1,41 @@ +#!/bin/bash +# SPDX-License-Identifier: MIT + +set -euxo pipefail + +. drivers/gpu/drm/ci/override-ld-with-bfd.sh + +apt-get update -qq +pip3 install dtschema + +case "${KERNEL_ARCH}" in + "arm") + GCC_ARCH="arm-linux-gnueabihf" + ;; + "arm64") + GCC_ARCH="aarch64-linux-gnu" + ;; + "x86_64") + GCC_ARCH="x86_64-linux-gnu" + ;; + *) + echo "Unsupported architecture: ${KERNEL_ARCH}" + exit 1 + ;; +esac + +export ARCH="${KERNEL_ARCH}" +export CROSS_COMPILE="${GCC_ARCH}-" + +make `basename ${DEFCONFIG}` +make -j${FDO_CI_CONCURRENT:-4} dtbs + +if ! make -j${FDO_CI_CONCURRENT:-4} dtbs_check >/dev/null 2>dtbs-check.log; then + echo "ERROR: 'make dtbs_check' failed. Please check dtbs-check.log for details." + exit 1 +fi + +if [[ -s dtbs-check.log ]]; then + echo "WARNING: dtbs_check reported warnings. Please check dtbs-check.log for details." + exit 102 +fi diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab-ci.yml index 65adcd97e06b..9e61b49e9960 100644 --- a/drivers/gpu/drm/ci/gitlab-ci.yml +++ b/drivers/gpu/drm/ci/gitlab-ci.yml @@ -108,6 +108,7 @@ include: - drivers/gpu/drm/ci/static-checks.yml - drivers/gpu/drm/ci/build.yml - drivers/gpu/drm/ci/test.yml + - drivers/gpu/drm/ci/check-devicetrees.yml - 'https://gitlab.freedesktop.org/gfx-ci/lab-status/-/raw/main/lab-status.yml'