From patchwork Wed Apr 2 14:21:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?0JLQsNGC0L7RgNC+0L/QuNC9INCQ0L3QtNGA0LXQuQ==?= X-Patchwork-Id: 14036102 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39DFAC36017 for ; Wed, 2 Apr 2025 14:23:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9980110E180; Wed, 2 Apr 2025 14:23:09 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=crpt.ru header.i=@crpt.ru header.b="Bv92W5Xs"; dkim-atps=neutral Received: from mail.crpt.ru (mail1.crpt.ru [91.236.205.1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8DA4F10E180; Wed, 2 Apr 2025 14:23:07 +0000 (UTC) Received: from mail.crpt.ru ([192.168.60.4]) by mail.crpt.ru with ESMTP id 532ELdeE011735-532ELdeG011735 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=OK); Wed, 2 Apr 2025 17:21:39 +0300 Received: from EX2.crpt.local (192.168.60.4) by ex2.crpt.local (192.168.60.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Wed, 2 Apr 2025 17:21:40 +0300 Received: from EX2.crpt.local ([192.168.60.4]) by EX2.crpt.local ([192.168.60.4]) with mapi id 15.01.2507.044; Wed, 2 Apr 2025 17:21:40 +0300 From: =?utf-8?b?0JLQsNGC0L7RgNC+0L/QuNC9INCQ0L3QtNGA0LXQuQ==?= To: Harry Wentland CC: =?utf-8?b?0JLQsNGC0L7RgNC+0L/QuNC9INCQ0L3QtNGA0LXQuQ==?= , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Alex Hung , Dillon Varone , Roman Li , Ethan Carter Edwards , "Ivan Lipski" , Iswara Nagulendran , Hersen Wu , Rafal Ostrowski , "Alvin Lee" , Aric Cyr , "Dr. David Alan Gilbert" , Srinivasan Shanmugam , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "lvc-project@linuxtesting.org" Subject: [PATCH] drm/amd/display: Remove the redundant NULL check Thread-Topic: [PATCH] drm/amd/display: Remove the redundant NULL check Thread-Index: AQHbo9qMmPuxivrTRU6kDAkV7hJQVA== Date: Wed, 2 Apr 2025 14:21:39 +0000 Message-ID: <20250402142134.375176-1-a.vatoropin@crpt.ru> Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.200.60.21] x-kse-serverinfo: EX2.crpt.local, 9 x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: Clean, bases: 4/2/2025 11:23:00 AM x-kse-attachment-filter-triggered-rules: Clean x-kse-attachment-filter-triggered-filters: Clean x-kse-bulkmessagesfiltering-scan-result: protection disabled MIME-Version: 1.0 X-FEAS-Client-IP: 192.168.60.4 X-FE-Policy-ID: 2:4:0:SYSTEM DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; d=crpt.ru; s=crpt.ru; c=relaxed/relaxed; h=from:to:cc:subject:date:message-id:content-type:mime-version; bh=6PWrRiayky3wtjPN+LAvVDtngWKjutbwbMbRB4bNvY4=; b=Bv92W5XszD82x8OUXlHmeG3WxEyF8/J/xc7a3rLgP9XN7RvSRGP6LCf0oC8G0/C89pAE8sWkcJI/ ObK291pMPuTLT4qUOmA8JeKaPiKmT76ztfqwuec3lwEv5EVctNjlVDZT0JETAvUhk23sXybV3lne McLGNotTjU2XjUiz6txO8BAfj0GAq7ZEPpGpcdIPQAKDwOCEe7Yrbhkb6AAynnaBr8zhJf2LOs3u i6yY09Dd+B6hDMA+PHsAkgn5Kpp7CSsP3TiHRahzwz6aEFvCPd2iQX0OEwUX6N3VlNhat/xfXRE2 dQXjYOpr4gSH8qJcfT61QqqZlLaRa259dHuRYA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Andrey Vatoropin Static analysis shows that pointer "timing" cannot be NULL because it points to the object "struct dc_crtc_timing". Remove the extra NULL check. It is meaningless and harms the readability of the code. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Andrey Vatoropin Reviewed-by: Alex Hung --- drivers/gpu/drm/amd/display/dc/resource/dcn30/dcn30_resource.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn30/dcn30_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn30/dcn30_resource.c index 13202ce30d66..76e8c4dcf339 100644 --- a/drivers/gpu/drm/amd/display/dc/resource/dcn30/dcn30_resource.c +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn30/dcn30_resource.c @@ -1891,8 +1891,6 @@ static int get_refresh_rate(struct dc_state *context) /* check if refresh rate at least 120hz */ timing = &context->streams[0]->timing; - if (timing == NULL) - return 0; h_v_total = timing->h_total * timing->v_total; if (h_v_total == 0)