| Message ID | 2795b611-dfb9-eaf6-e04d-10e27ce96772@users.sourceforge.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Den 08.05.2017 13.54, skrev SF Markus Elfring: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Mon, 8 May 2017 13:42:03 +0200 > > A single character (line break) should be put into a sequence. > Thus use the corresponding function "seq_putc". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- Thanks, Acked-by: Noralf Trønnes <noralf@tronnes.org> > drivers/gpu/drm/tinydrm/mipi-dbi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c > index f4eb412f3604..54d66b732d55 100644 > --- a/drivers/gpu/drm/tinydrm/mipi-dbi.c > +++ b/drivers/gpu/drm/tinydrm/mipi-dbi.c > @@ -946,7 +946,7 @@ static int mipi_dbi_debugfs_command_show(struct seq_file *m, void *unused) > > for (i = 0; i < len; i++) > seq_printf(m, "%02x", val[i]); > - seq_puts(m, "\n"); > + seq_putc(m, '\n'); > } > > return 0;
On Tue, 2017-05-09 at 19:29 +0200, Noralf Trønnes wrote: > Den 08.05.2017 13.54, skrev SF Markus Elfring: > > A single character (line break) should be put into a sequence. > > Thus use the corresponding function "seq_putc". Markus, I know this is hard for you, but think more before sending patches. > > diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c [] > > @@ -946,7 +946,7 @@ static int mipi_dbi_debugfs_command_show(struct seq_file *m, void *unused) > > > > for (i = 0; i < len; i++) > > seq_printf(m, "%02x", val[i]); > > - seq_puts(m, "\n"); > > + seq_putc(m, '\n'); Use the %p<foo> extensions. seq_printf(m, "%*phN\n", len, val)
diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c index f4eb412f3604..54d66b732d55 100644 --- a/drivers/gpu/drm/tinydrm/mipi-dbi.c +++ b/drivers/gpu/drm/tinydrm/mipi-dbi.c @@ -946,7 +946,7 @@ static int mipi_dbi_debugfs_command_show(struct seq_file *m, void *unused) for (i = 0; i < len; i++) seq_printf(m, "%02x", val[i]); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } return 0;