| Message ID | 38bd05d3-79ad-4dd5-8eb6-328ac0ac1ae8@email.android.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Please completely ignore that mail, my fatty fingers have selected the wrong mail for replying. Regards, Christian. On 13.07.2015 09:08, Koenig, Christian wrote: > > Hi Jammy, > > I suggested to make the feature optional because of the unit test's. > > There we don't need this feature and actually want to test the kernel > functionality. > > Regards, > Christian. > > Am 13.07.2015 08:45 schrieb Archit Taneja <architt@codeaurora.org>: > > Remove FB_* config options since the driver doesn't call any fbdev > functions directly. > > Remove FB_KMS_HELPER as this would now be selected by the top level > FBDEV_EMULATION config option. If the fbdev emulation isn't selected, > the drm_fb_helper functions will be stubbed out. > > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: Oded Gabbay <oded.gabbay@gmail.com> > Cc: "Christian König" <christian.koenig@amd.com> > > Signed-off-by: Archit Taneja <architt@codeaurora.org> > --- > drivers/gpu/drm/amd/amdgpu/Kconfig | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig > b/drivers/gpu/drm/amd/amdgpu/Kconfig > index da7dcbf..2396482 100644 > --- a/drivers/gpu/drm/amd/amdgpu/Kconfig > +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig > @@ -1,12 +1,8 @@ > config DRM_AMDGPU > tristate "AMD GPU" > depends on DRM && PCI > - select FB_CFB_FILLRECT > - select FB_CFB_COPYAREA > - select FB_CFB_IMAGEBLIT > select FW_LOADER > select DRM_KMS_HELPER > - select DRM_KMS_FB_HELPER > select DRM_TTM > select POWER_SUPPLY > select HWMON > -- > The Qualcomm Innovation Center, Inc. is a member of the Code > Aurora Forum, > hosted by The Linux Foundation > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig index da7dcbf..2396482 100644 --- a/drivers/gpu/drm/amd/amdgpu/Kconfig +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig @@ -1,12 +1,8 @@ config DRM_AMDGPU tristate "AMD GPU" depends on DRM && PCI - select FB_CFB_FILLRECT - select FB_CFB_COPYAREA - select FB_CFB_IMAGEBLIT select FW_LOADER select DRM_KMS_HELPER - select DRM_KMS_FB_HELPER select DRM_TTM select POWER_SUPPLY select HWMON
Hi Jammy, I suggested to make the feature optional because of the unit test's. There we don't need this feature and actually want to test the kernel functionality. Regards, Christian. Am 13.07.2015 08:45 schrieb Archit Taneja <architt@codeaurora.org>: Remove FB_* config options since the driver doesn't call any fbdev functions directly. Remove FB_KMS_HELPER as this would now be selected by the top level FBDEV_EMULATION config option. If the fbdev emulation isn't selected, the drm_fb_helper functions will be stubbed out. Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Oded Gabbay <oded.gabbay@gmail.com> Cc: "Christian König" <christian.koenig@amd.com> Signed-off-by: Archit Taneja <architt@codeaurora.org> --- drivers/gpu/drm/amd/amdgpu/Kconfig | 4 ---- 1 file changed, 4 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation