diff mbox

video: fsl-diu-fb: Delete an error message for a failed memory allocation in fsl_diu_init()

Message ID 39d05a48-e649-fb88-0e86-4f7528fd67f8@users.sourceforge.net (mailing list archive)
State New, archived
Headers show

Commit Message

SF Markus Elfring Nov. 27, 2017, 9 a.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 27 Nov 2017 09:56:09 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/video/fbdev/fsl-diu-fb.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Timur Tabi Nov. 27, 2017, 5:31 p.m. UTC | #1 
On 11/27/17 3:00 AM, SF Markus Elfring wrote:
> From: Markus Elfring<elfring@users.sourceforge.net>
> Date: Mon, 27 Nov 2017 09:56:09 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring<elfring@users.sourceforge.net>

Acked-by: Timur Tabi <timur@tabi.org>
Bartlomiej Zolnierkiewicz March 28, 2018, 2 p.m. UTC | #2 
On Monday, November 27, 2017 11:31:10 AM Timur Tabi wrote:
> On 11/27/17 3:00 AM, SF Markus Elfring wrote:
> > From: Markus Elfring<elfring@users.sourceforge.net>
> > Date: Mon, 27 Nov 2017 09:56:09 +0100
> > 
> > Omit an extra message for a memory allocation failure in this function.
> > 
> > This issue was detected by using the Coccinelle software.
> > 
> > Signed-off-by: Markus Elfring<elfring@users.sourceforge.net>
> 
> Acked-by: Timur Tabi <timur@tabi.org>

Patch queued for 4.17, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
diff mbox

Patch

diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
index 25abbcf38913..1bfd13cbd4e3 100644
--- a/drivers/video/fbdev/fsl-diu-fb.c
+++ b/drivers/video/fbdev/fsl-diu-fb.c
@@ -1960,12 +1960,8 @@  static int __init fsl_diu_init(void)
 
 	of_node_put(np);
 	coherence_data = vmalloc(coherence_data_size);
-	if (!coherence_data) {
-		pr_err("fsl-diu-fb: could not allocate coherence data "
-		       "(size=%zu)\n", coherence_data_size);
+	if (!coherence_data)
 		return -ENOMEM;
-	}
-
 #endif
 
 	ret = platform_driver_register(&fsl_diu_driver);