From patchwork Thu Jan 20 18:53:16 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Bullock X-Patchwork-Id: 492451 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p0KJAYXx015447 for ; Thu, 20 Jan 2011 19:10:55 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 243919EC16 for ; Thu, 20 Jan 2011 11:10:34 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 20 Jan 2011 19:10:55 +0000 (UTC) X-Greylist: delayed 1025 seconds by postgrey-1.31 at gabe; Thu, 20 Jan 2011 11:10:24 PST Received: from exprod8og103.obsmtp.com (exprod8og103.obsmtp.com [64.18.3.86]) by gabe.freedesktop.org (Postfix) with ESMTP id 1AD6B9E74C for ; Thu, 20 Jan 2011 11:10:23 -0800 (PST) Received: from source ([207.170.222.181]) (using TLSv1) by exprod8ob103.postini.com ([64.18.7.12]) with SMTP ID DSNKTTiInktGyDOIzUz81LMhVBcI523lmLEt@postini.com; Thu, 20 Jan 2011 11:10:24 PST Received: from exchange.tadpole.tad ([192.168.1.12]) by obelix.itronix.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 20 Jan 2011 10:54:05 -0800 Received: from [192.168.64.20] ([192.168.64.20]) by exchange.tadpole.tad with Microsoft SMTPSVC(6.0.3790.4675); Thu, 20 Jan 2011 10:53:17 -0800 Message-ID: <4D38849C.5020808@tadpole.com> Date: Thu, 20 Jan 2011 10:53:16 -0800 From: Matthew Bullock User-Agent: Thunderbird 2.0.0.21 (X11/20090311) MIME-Version: 1.0 To: dri-devel@lists.freedesktop.org Subject: Broken locking in ttm_bo_swapout X-OriginalArrivalTime: 20 Jan 2011 18:53:17.0375 (UTC) FILETIME=[4CA604F0:01CBB8D3] X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org --- ttm_bo.c~ 2011-01-05 00:50:19.000000000 +0000 +++ ttm_bo.c 2011-01-20 18:11:57.262813765 +0000 @@ -1761,6 +1761,7 @@ static int ttm_bo_swapout(struct ttm_mem spin_unlock(&glob->lru_lock); (void) ttm_bo_cleanup_refs(bo, false, false, false); kref_put(&bo->list_kref, ttm_bo_release_list); + spin_lock(&glob->lru_lock); continue; }