From patchwork Fri Jan 21 08:35:41 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 494481 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p0L8Zrp6016756 for ; Fri, 21 Jan 2011 08:36:14 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 868B19EF65 for ; Fri, 21 Jan 2011 00:35:52 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-fx0-f49.google.com (mail-fx0-f49.google.com [209.85.161.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 4607B9E730 for ; Fri, 21 Jan 2011 00:35:44 -0800 (PST) Received: by fxm19 with SMTP id 19so1528414fxm.36 for ; Fri, 21 Jan 2011 00:35:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=ojtxFN9+LDvFknu5MF5mrHi192bN2huHnyxN8zGRxJI=; b=Ypd1SgRpdyLVme3dpXAXURls1723nD/nbtW+BXvpFAqeF+upHwai+FI8i7jhFesoA4 6zSwhAlwj7HRIqmsBs60XwqQDVZVCiP1CZJC7EQmq2I7QQp8AQg+5WzEJmhs9qXXhhFt WZNjGRlKEKcj3X1BRDa4UXX9m+vZvuKNEDniw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=lDSiF/ACZ5VfmciIhPefuOdsLwYNcoIwY0RNrq1OLHM/7atvnFZlU3FVgO5eMV7HgA B2r/Wv2yN7gp5ortCB0UdwbwXcbs2uHbbpHGsR0QtBWgyuMR4qO+8jO3pjTsZ3AEFCtf jPPUn12kIXl7Yy+qUBR3exvvpONnoDpEelc5M= Received: by 10.223.72.197 with SMTP id n5mr400974faj.8.1295598943504; Fri, 21 Jan 2011 00:35:43 -0800 (PST) Received: from [192.168.2.129] ([217.66.174.142]) by mx.google.com with ESMTPS id n3sm3480219faa.5.2011.01.21.00.35.41 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 21 Jan 2011 00:35:42 -0800 (PST) Message-ID: <4D39455D.4070808@gmail.com> Date: Fri, 21 Jan 2011 09:35:41 +0100 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.2.13) Gecko/20101206 SUSE/3.1.7 Thunderbird/3.1.7 MIME-Version: 1.0 To: Chris Wilson Subject: Re: [PATCH] drm/i915/ringbuffer: Fix use of stale HEAD position whilst polling for space References: <1295545279-21335-1-git-send-email-chris@chris-wilson.co.uk> In-Reply-To: <1295545279-21335-1-git-send-email-chris@chris-wilson.co.uk> X-Enigmail-Version: 1.1.2 Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 21 Jan 2011 08:36:14 +0000 (UTC) --- a/drivers/gpu/drm/i915/intel_ringbuffer.h +++ b/drivers/gpu/drm/i915/intel_ringbuffer.h @@ -52,7 +52,7 @@ struct intel_ring_buffer { u32 irq_seqno; /* last seq seem at irq time */ u32 waiting_seqno; - u32 sync_seqno[I915_NUM_RINGS-1]; + u32 sync_seqno[I915_NUM_RINGS]; atomic_t irq_refcount; bool __must_check (*irq_get)(struct intel_ring_buffer *ring);