From patchwork Mon Jun 2 11:48:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 4281321 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3BEE3BEEA7 for ; Mon, 2 Jun 2014 11:49:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 375C1202A1 for ; Mon, 2 Jun 2014 11:49:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 9CCEB2012F for ; Mon, 2 Jun 2014 11:49:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5A716E558; Mon, 2 Jun 2014 04:49:00 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by gabe.freedesktop.org (Postfix) with ESMTP id D0CA56E558 for ; Mon, 2 Jun 2014 04:48:59 -0700 (PDT) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N6J00DKKI5GMM00@mailout4.w1.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 02 Jun 2014 12:48:52 +0100 (BST) X-AuditID: cbfec7f4-b7fac6d000006cfe-a7-538c64a99ae1 Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 05.F0.27902.9A46C835; Mon, 02 Jun 2014 12:48:57 +0100 (BST) Received: from [106.116.147.88] by eusync1.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0N6J00HZKI5KVQ30@eusync1.samsung.com>; Mon, 02 Jun 2014 12:48:57 +0100 (BST) Message-id: <538C64A7.50900@samsung.com> Date: Mon, 02 Jun 2014 13:48:55 +0200 From: Andrzej Hajda User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 Newsgroups: gmane.linux.kernel.samsung-soc,gmane.comp.video.dri.devel To: Tomasz Figa , Rahul Sharma Subject: Re: [PATCH] drm/exynos: remove hardware overlays disable from fimd probe References: <1401257471-31994-1-git-send-email-rahul.sharma@samsung.com> <538C3FC4.6090509@samsung.com> <538C4DE0.50801@gmail.com> <538C551E.30407@samsung.com> In-reply-to: <538C551E.30407@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsVy+t/xy7orU3qCDZZeF7W48vU9m8Wk+xNY LL7v+sJu0bvgKpvFjPP7mCzWHrnLbjFl0WFWi1W7/jA6cHjsnHWX3eN+93Emj74tqxg9Pm+S C2CJ4rJJSc3JLEst0rdL4Mr4NWU3a8FmkYpvuz+yNzA2C3QxcnJICJhIvPo4kRXCFpO4cG89 G4gtJLCUUeLTfecuRi4g+xOjxNFDx5lBErwCGhIXZ04Fa2ARUJV4tWImWJxNQFPi7+abQM0c HKICERKPLwhBlAtK/Jh8jwXE5hNwldh+/QATiC0iECCx4t46dpD5zAKzmCS2P17IBNIrLBAs cf+dAcTeV4wS57f2g+3iBJq/ZPYbsEHMAjoS+1unsUHY8hKb17xlnsAoOAvJvllIymYhKVvA yLyKUTS1NLmgOCk911CvODG3uDQvXS85P3cTIyT4v+xgXHzM6hCjAAejEg+vgndPsBBrYllx Ze4hRgkOZiUR3qUWQCHelMTKqtSi/Pii0pzU4kOMTBycUg2M2h/fcFaU6S548eKo+dWX0ibP Czn918iEeTs0N11iNW7aGxDvMpe3M16i2bxzRYeVz6p1e0/PlXHeIOm582jYRx3O+NkdG2ae SV7Wfvs6/9Sel2oTN8YsesDB/ebxyzWL5q76fa1r660L+h/3Gnw/mre07xVbyxPJlP7/OfuC mg8rzz7SOnuSmhJLcUaioRZzUXEiABWx/3ZcAgAA Cc: linux-samsung-soc , sunil joshi , "dri-devel@lists.freedesktop.org" , Kukjin Kim , "Szyprowski, Marek" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 06/02/2014 12:42 PM, Andrzej Hajda wrote: > On 06/02/2014 12:11 PM, Tomasz Figa wrote: >> Hi Rahul, Andrzej, >> >> On 02.06.2014 11:42, Rahul Sharma wrote: >>> On 2 June 2014 14:41, Andrzej Hajda wrote: >>>> Hi Rahul, >>>> >>>> On 05/28/2014 08:11 AM, Rahul Sharma wrote: >>>>> System hangs when FIMD registers are accessed to disable >>>>> hardware overlays. This is because of the clocks which are >>>>> not enabled before register access. >>>>> >>>>> 'Hardware overlay disable' is cleaned from the FIMD probe. >>>>> >>>>> Signed-off-by: Rahul Sharma >>>> >>>> This patch causes regression on some exynos4210-universal_c210 devices, >>>> everything works expect colors are incorrect - it seems blue component >>>> is very dark, almost black. >>>> >>> >>> Oh.... Sorry for that. I did not see any problem on 5250/5420/5800. I do not >>> have setup for 4210. Better we should revert this patch. >>> >>> Would you please help me by verifying the following patch on 4210? This >>> is an alternate solution to the same problem. >>> >>> http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg31426.html >>> >>> Thanks Andrej, for bringing it to notice. >> >> I don't see how this patch could introduce such regression, as all the >> affected registers seem to be properly reconfigured in fimd_win_commit() >> anyway. >> >> IMHO instead of reverting the patch, this issue should be investigated >> and fixed properly. >> >> Best regards, >> Tomasz >> > > I am looking at the problem, it is quite strange as it happens only on > one of two targets I have access to. Anyway it seems that something > should be added to fimd initialization sequence if we want to remove hw > accessing code from probe. The problem is that fimd does not clear unused windows. Simple patch which helps: But I am not fully familiar with window management code, so I do not know if it does not breaks other stuff. Regards Andrzej > > Regards > Andrzej > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 2ec634f..b58fce2 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -741,6 +741,8 @@ static void fimd_apply(struct exynos_drm_manager *mgr) win_data = &ctx->win_data[i]; if (win_data->enabled) fimd_win_commit(mgr, i); + else + fimd_win_disable(mgr, i); } fimd_commit(mgr);