From patchwork Tue Jul 29 11:21:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andreas_F=C3=A4rber?= X-Patchwork-Id: 4646241 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5C340C0338 for ; Wed, 30 Jul 2014 08:08:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3D19120149 for ; Wed, 30 Jul 2014 08:08:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 3BC5120123 for ; Wed, 30 Jul 2014 08:08:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E1BB36E599; Wed, 30 Jul 2014 01:08:12 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C23E6E148 for ; Tue, 29 Jul 2014 04:21:54 -0700 (PDT) Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 2D58AAAF3; Tue, 29 Jul 2014 11:21:51 +0000 (UTC) Message-ID: <53D783CC.2080108@suse.de> Date: Tue, 29 Jul 2014 13:21:48 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Ajay kumar Subject: Re: [PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support References: <1406316130-4744-1-git-send-email-ajaykumar.rs@samsung.com> <53D5435B.8030305@suse.de> In-Reply-To: X-Enigmail-Version: 1.6 X-Mailman-Approved-At: Wed, 30 Jul 2014 01:08:11 -0700 Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, seanpaul@google.com, daniel.vetter@ffwll.ch, joshi@samsung.com, dri-devel@lists.freedesktop.org, Doug Anderson , Javier Martinez Canillas , prashanth.g@samsung.com, Ajay Kumar X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Ajay, Am 28.07.2014 08:13, schrieb Ajay kumar: > On 7/27/14, Andreas Färber wrote: >> Am 25.07.2014 21:22, schrieb Ajay Kumar: >>> This series is based on exynos-drm-next branch of Inki Dae's tree at: >>> git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git >>> >>> I have tested this after adding few DT changes for exynos5250-snow, >>> exynos5420-peach-pit and exynos5800-peach-pi boards. >> >> I'm trying to test this with a modified exynos5250-spring DT based off >> kgene's for-next branch due to DT, and I run into the following: >> >> CC drivers/gpu/drm/bridge/ptn3460.o >> drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_post_encoder_init’: >> drivers/gpu/drm/bridge/ptn3460.c:275:2: error: implicit declaration of >> function ‘drm_connector_register’ [-Werror=implicit-function-declaration] >> drm_connector_register(&ptn_bridge->connector); >> ^ > Hope this might help: > http://www.spinics.net/lists/dri-devel/msg60578.html That fixed my build, thanks. Unfortunately the most I got on Spring with attached DT was a blank screen with a white horizontal line in the middle. Do I need to specify a specific panel model for Spring? For testing I re-applied your iommu patches (which btw fail now for 5420 due to disp_pd) but didn't know what to do about your panel-lvds regulator patch now that it's gone. If I don't apply this series, then commenting out the dp-controller node gets me a working display with simplefb as before. Regards, Andreas From 9172a26a8f0d0f0d170bd27e1c150ad204d8086a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Sun, 27 Jul 2014 21:58:06 +0200 Subject: [PATCH] ARM: dts: exynos5250: Add eDP/LVDS bridge to Spring MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Ajay Kumar [AF: Redone for v6] Signed-off-by: Andreas Färber --- arch/arm/boot/dts/exynos5250-spring.dts | 32 +++++++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts index 687dfab86bc8..517b1ff2bfdf 100644 --- a/arch/arm/boot/dts/exynos5250-spring.dts +++ b/arch/arm/boot/dts/exynos5250-spring.dts @@ -64,10 +64,14 @@ vdd_pll-supply = <&s5m_ldo8_reg>; }; + panel: panel { + compatible = "simple-panel"; + }; + dp-controller@145B0000 { status = "okay"; pinctrl-names = "default"; - pinctrl-0 = <&dp_hpd>; + pinctrl-0 = <&dp_hpd_gpio>; samsung,color-space = <0>; samsung,dynamic-range = <0>; samsung,ycbcr-coeff = <0>; @@ -75,6 +79,7 @@ samsung,link-rate = <0x0a>; samsung,lane-count = <1>; samsung,hpd-gpio = <&gpc3 0 0>; + bridge = <&ps8622>; }; fixed-rate-clocks { @@ -387,6 +392,17 @@ status = "okay"; samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <66000>; + + ps8622: ps8622-bridge@08 { + compatible = "parade,ps8622"; + reg = <0x08>; + sleep-gpios = <&gpc3 6 0>; + reset-gpios = <&gpc3 1 0>; + lane-count = <1>; + panel = <&panel>; + pinctrl-names = "default"; + pinctrl-0 = <&ps8622_gpios>; + }; }; &i2c_8 { @@ -450,6 +466,20 @@ samsung,pin-pud = <0>; }; + dp_hpd_gpio: dp-hpd-gpio { + samsung,pins = "gpc3-0"; + samsung,pin-function = <0>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + ps8622_gpios: ps8622-gpios { + samsung,pins = "gpc3-1", "gpc3-6"; + samsung,pin-function = <1>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + s5m8767_dvs: s5m8767-dvs { samsung,pins = "gpd1-0", "gpd1-1", "gpd1-2"; samsung,pin-function = <0>; -- 1.9.3