From patchwork Thu Mar 26 14:49:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 6099831 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AA0739F2A9 for ; Thu, 26 Mar 2015 14:49:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CF0BC20155 for ; Thu, 26 Mar 2015 14:49:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id A6222203E5 for ; Thu, 26 Mar 2015 14:49:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BAF346EA12; Thu, 26 Mar 2015 07:49:52 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 172B76EA12 for ; Thu, 26 Mar 2015 07:49:51 -0700 (PDT) Received: by wibg7 with SMTP id g7so151467141wib.1 for ; Thu, 26 Mar 2015 07:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=xWKxBCTU346vHpknaKFsdSl6bn35MtUOduLZ3FEBBYI=; b=odGvkPtS3qnDXh1jfPDX/L9TqYpH6SgGSBjZSuOEwygiwsojDfwR+YgL0wVJlRDmri +6fn4Xga/tRPaVBmil+cRL9XiReLi8EDtPbb8WcCDxCEpMVew8Hkwkxt1jSeAw7J1kPP k62DtsJnnLwvlYCqt83itlbh2GwzeSPqQruhrlempTsGsZDvbiW9wrkEPP0hogL5u0Vs smHL12aXvlTS31GTj7jImStenBtSqEhP8qf+lBBXWaxZcpxRgBmZyQ5geSxuFEnDlHaN RozV0vHZD3Mi37+kgS42Uw5sbanr++gCF1YnJmLBRaYN7XPGBypb6aIOVZb/DCapcHzg YJow== X-Received: by 10.194.24.103 with SMTP id t7mr28335003wjf.15.1427381389391; Thu, 26 Mar 2015 07:49:49 -0700 (PDT) Received: from [192.168.152.4] (cpc12-croy20-2-0-cust52.croy.cable.virginm.net. [82.44.54.53]) by mx.google.com with ESMTPSA id dq8sm9307197wib.9.2015.03.26.07.49.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Mar 2015 07:49:48 -0700 (PDT) Message-ID: <55141C90.3040305@gmail.com> Date: Thu, 26 Mar 2015 14:49:52 +0000 From: Emil Velikov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Jan Vesely , dri-devel@lists.freedesktop.org Subject: Re: [PATCH libdrm 2/3] tests/drmsl: Extract tests out of xf86drmSL.c References: <550EDD46.2060901@gmail.com> <1427238406-25103-1-git-send-email-jan.vesely@rutgers.edu> In-Reply-To: <1427238406-25103-1-git-send-email-jan.vesely@rutgers.edu> Cc: emil.l.velikov@gmail.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 24/03/15 23:06, Jan Vesely wrote: > v2: merge tests creation and xf86drmSL cleanup > rename tests/drmsltest -> tests/drmsl > move the test out of libudev test block > > Signed-off-by: Jan Vesely > --- > > Hi Emil, > I know you send your R-b on the earlier version, but I thought the changes > were big enough to send v2. I modeled it after you test splitting series. > > jan > > .gitignore | 1 + > tests/Makefile.am | 5 +- > tests/drmsl.c | 172 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > xf86drmSL.c | 172 ++---------------------------------------------------- > 4 files changed, 183 insertions(+), 167 deletions(-) > create mode 100644 tests/drmsl.c > > diff --git a/.gitignore b/.gitignore > index 06cc928..cb7128d 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -74,6 +74,7 @@ tdfx.kld > via.kld > tests/auth > tests/dristat > +tests/drmsl > tests/drmstat > tests/getclient > tests/getstats Hmm this reminds me that I missed out updating the .gitignore with my series. > diff --git a/tests/Makefile.am b/tests/Makefile.am > index 10f54e3..ad70314 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -35,6 +35,9 @@ if HAVE_NOUVEAU > SUBDIRS += nouveau > endif > > +TESTS = \ > + drmsl > + > if HAVE_LIBUDEV > > check_LTLIBRARIES = libdrmtest.la > @@ -52,7 +55,7 @@ XFAIL_TESTS = \ > auth \ > lock > > -TESTS = \ > +TESTS += \ > openclose \ > getversion \ > getclient \ You will need the following hunk, otherwise drmsl will not end up in the check target. Although when I think about it there isn't much value in running this at make check time. I'll leave the decision up-to you. As before haven't explicitly checked the moved code so Acked-by: Emil Velikov Thanks Emil --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -61,6 +61,7 @@ TESTS = \ updatedraw \ name_from_fd +endif + check_PROGRAMS += $(TESTS) -endif