diff mbox series

[v4,2/3] dt-bindings: Add Rocktech jh057n00900 panel bindings

Message ID 6a50cfdf0fd68aa120f7d8b67357ab45a2275355.1553522676.git.agx@sigxcpu.org (mailing list archive)
State New, archived
Headers show
Series drm/panel: Support Rocktech jh057n00900 DSI panel | expand

Commit Message

Guido Günther March 25, 2019, 2:06 p.m. UTC 
The Rocktec jh057n00900 is a 5.5" MIPI DSI video mode panel with a
720x1440 resolution and a built in backlight.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
 .../display/panel/rocktech,jh057n00900.txt     | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt

Comments

Fabio Estevam March 25, 2019, 2:10 p.m. UTC | #1 
On Mon, Mar 25, 2019 at 11:06 AM Guido Günther <agx@sigxcpu.org> wrote:

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt
> @@ -0,0 +1,18 @@
> +Rocktech jh057n00900 5.5" 720x1440 TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "rocktech,jh057n00900"
> +- reg: DSI virtual channel of the peripheral
> +- reset-gpios: panel reset gpio
> +- backlight: phandle of the backlight device attached to the panel
> +
> +Example:
> +
> +       &mipi_dsi {
> +               panel {
> +                       compatible = "rocktech,jh057n00900";
> +                       reg = <0>;

Passing the reg property without its corresponding @0 would cause a
dtc warning when building with W=1.
Guido Günther March 25, 2019, 4:10 p.m. UTC | #2 
Hi,
On Mon, Mar 25, 2019 at 11:10:47AM -0300, Fabio Estevam wrote:
> On Mon, Mar 25, 2019 at 11:06 AM Guido Günther <agx@sigxcpu.org> wrote:
> 
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt
> > @@ -0,0 +1,18 @@
> > +Rocktech jh057n00900 5.5" 720x1440 TFT LCD panel
> > +
> > +Required properties:
> > +- compatible: should be "rocktech,jh057n00900"
> > +- reg: DSI virtual channel of the peripheral
> > +- reset-gpios: panel reset gpio
> > +- backlight: phandle of the backlight device attached to the panel
> > +
> > +Example:
> > +
> > +       &mipi_dsi {
> > +               panel {
> > +                       compatible = "rocktech,jh057n00900";
> > +                       reg = <0>;
> 
> Passing the reg property without its corresponding @0 would cause a
> dtc warning when building with W=1.

Thanks, I've put that in for v5 and sent a patch to correct
the other drivers in display/panel:

  https://patchwork.kernel.org/patch/10869563/

Cheers,
 -- Guido
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt
new file mode 100644
index 000000000000..32f4001d2d6f
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt
@@ -0,0 +1,18 @@ 
+Rocktech jh057n00900 5.5" 720x1440 TFT LCD panel
+
+Required properties:
+- compatible: should be "rocktech,jh057n00900"
+- reg: DSI virtual channel of the peripheral
+- reset-gpios: panel reset gpio
+- backlight: phandle of the backlight device attached to the panel
+
+Example:
+
+	&mipi_dsi {
+		panel {
+			compatible = "rocktech,jh057n00900";
+			reg = <0>;
+			backlight = <&backlight>;
+			reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
+		};
+	};