| Message ID | 767d36ff-22ec-8136-7ebc-1d9d0d3ac98d@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] video: fbdev: amifb: add FIXME about dead APUS support | expand |
On Tue, Jun 2, 2020 at 1:50 PM Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > On 5/14/20 10:21 PM, Geert Uytterhoeven wrote: > > These #ifdefs are relics from APUS (Amiga Power-Up System), which > > added a PPC board. APUS support was killed off a long time ago, > > when arch/ppc/ was still king, but these #ifdefs were missed, because > > they didn't test for CONFIG_APUS. > > Add FIXME about using the C code variants (APUS ones) in the future. > > Reported-by: Al Viro <viro@zeniv.linux.org.uk> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert
On Tue, Jun 02, 2020 at 02:03:12PM +0200, Geert Uytterhoeven wrote: > On Tue, Jun 2, 2020 at 1:50 PM Bartlomiej Zolnierkiewicz > <b.zolnierkie@samsung.com> wrote: > > On 5/14/20 10:21 PM, Geert Uytterhoeven wrote: > > > These #ifdefs are relics from APUS (Amiga Power-Up System), which > > > added a PPC board. APUS support was killed off a long time ago, > > > when arch/ppc/ was still king, but these #ifdefs were missed, because > > > they didn't test for CONFIG_APUS. > > > > Add FIXME about using the C code variants (APUS ones) in the future. > > > > Reported-by: Al Viro <viro@zeniv.linux.org.uk> > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> FWIW, has anyone managed to boot m68k linux kernel on e.g. FS-UAE? I have done that on aranym (which is how I'd been doing all testing for e.g. signal-related m68k patches) and I've seen references to some out-of-tree qemu variant doing quadra, but nothing for amiga emulators...
On Tue, 2 Jun 2020, Al Viro wrote: > I have done that on aranym (which is how I'd been doing all testing for > e.g. signal-related m68k patches) and I've seen references to some > out-of-tree qemu variant doing quadra, but nothing for amiga > emulators... > Laurent Vivier's Quadra 800 emulation is no longer out of tree. It appeared in QEMU v4.2.0 and ethernet support was stabilized in QEMU v5.0.0.
On 6/2/20 2:03 PM, Geert Uytterhoeven wrote: > On Tue, Jun 2, 2020 at 1:50 PM Bartlomiej Zolnierkiewicz > <b.zolnierkie@samsung.com> wrote: >> On 5/14/20 10:21 PM, Geert Uytterhoeven wrote: >>> These #ifdefs are relics from APUS (Amiga Power-Up System), which >>> added a PPC board. APUS support was killed off a long time ago, >>> when arch/ppc/ was still king, but these #ifdefs were missed, because >>> they didn't test for CONFIG_APUS. >> >> Add FIXME about using the C code variants (APUS ones) in the future. >> >> Reported-by: Al Viro <viro@zeniv.linux.org.uk> >> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> >> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Applied to drm-misc-next tree. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
Index: b/drivers/video/fbdev/amifb.c =================================================================== --- a/drivers/video/fbdev/amifb.c +++ b/drivers/video/fbdev/amifb.c @@ -575,6 +575,12 @@ static u_short maxfmode, chipset; #define downx(x, v) ((v) & -(x)) #define modx(x, v) ((v) & ((x) - 1)) +/* + * FIXME: Use C variants of the code marked with #ifdef __mc68000__ + * in the driver. It shouldn't negatively affect the performance and + * is required for APUS support (once it is re-added to the kernel). + * Needs to be tested on the hardware though.. + */ /* if x1 is not a constant, this macro won't make real sense :-) */ #ifdef __mc68000__ #define DIVUL(x1, x2) ({int res; asm("divul %1,%2,%3": "=d" (res): \