From patchwork Sat Dec 27 17:18:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keith Packard X-Patchwork-Id: 5544821 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (unknown [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D487CBF6C3 for ; Sat, 27 Dec 2014 21:35:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 17712201EF for ; Sat, 27 Dec 2014 21:35:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 9955F20176 for ; Sat, 27 Dec 2014 21:34:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4657C89BA9; Sat, 27 Dec 2014 09:18:55 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from elaine.keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 511DE89BA9; Sat, 27 Dec 2014 09:18:54 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by elaine.keithp.com (Postfix) with ESMTP id 0DA973F20028; Sat, 27 Dec 2014 09:18:54 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at keithp.com Received: from elaine.keithp.com ([127.0.0.1]) by localhost (elaine.keithp.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8rTtdZCw2EFC; Sat, 27 Dec 2014 09:18:49 -0800 (PST) Received: by elaine.keithp.com (Postfix, from userid 1033) id 91D763F2084C; Sat, 27 Dec 2014 09:18:49 -0800 (PST) Received: from hiro.keithp.com (localhost [127.0.0.1]) by elaine.keithp.com (Postfix) with ESMTP id 70FD63F20028; Sat, 27 Dec 2014 09:18:49 -0800 (PST) Received: by hiro.keithp.com (Postfix, from userid 1001) id 2AF1B740146; Sat, 27 Dec 2014 09:18:49 -0800 (PST) From: Keith Packard To: Kertesz Laszlo , Michel =?utf-8?Q?D=C3=A4nze?= =?utf-8?Q?r?= Subject: Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor) In-Reply-To: <1419594203.1679.1.camel@gmail.com> References: <544F885B.9030206@gmail.com> <1418940218.6596.49.camel@gmail.com> <1419552090.3950.3.camel@gmail.com> <549CB954.9060602@daenzer.net> <1419563434.3950.9.camel@gmail.com> <549CD359.1020608@daenzer.net> <1419594203.1679.1.camel@gmail.com> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Sat, 27 Dec 2014 09:18:45 -0800 Message-ID: <86a929ypsa.fsf@hiro.keithp.com> MIME-Version: 1.0 Cc: "List, X.Org" , Maling list - DRI developers X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Kertesz Laszlo writes: > Ok, rebuilt the xserver package with debugging symbols (seems that > checkinstall strips stuff by default). I got a bigger gdb.txt. See if it > helps. I found a bug -- glamor_xv_put_image was mis-computing the number of lines of changed video when the client drew only a subset of the image. I think the client is drawing at src_y=1, src_h=239 for some weird reason (I suspect a bug in the client). Try this patch: Reviewed-by: Eric Anholt From eaa4225413b31314070f9a52d9290649e79a3b0f Mon Sep 17 00:00:00 2001 From: Keith Packard Date: Sat, 27 Dec 2014 09:11:33 -0800 Subject: [PATCH] glamor: Fix nlines in glamor_xv_put_image when src_y is odd The number of lines of video to update in the texture needs to be computed from the height of the updated source, not the full height of the source. Signed-off-by: Keith Packard --- glamor/glamor_xv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glamor/glamor_xv.c b/glamor/glamor_xv.c index 1c877da..83e24ad 100644 --- a/glamor/glamor_xv.c +++ b/glamor/glamor_xv.c @@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv, } top = (src_y) & ~1; - nlines = (src_y + height) - top; + nlines = (src_y + src_h) - top; switch (id) { case FOURCC_YV12: -- 2.1.4