| Message ID | 87ece3775c9491fb2173f3bbe96cbe407b8ae756.1686923622.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/atomic-helper: Update reference to drm_crtc_force_disable_all() | expand |
Hi, Nice patch! By the way, thomas also fix a bug[1] by calling drm_helper_force_disable_all() function So this function seems useful. It deserved learn for a while. :-) [1] https://patchwork.freedesktop.org/patch/541906/?series=119144&rev=1 On 2023/6/16 21:54, Geert Uytterhoeven wrote: > drm_crtc_force_disable_all() was renamed to > drm_helper_force_disable_all(), but one reference was not updated. > > Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by Sui Jingfeng <suijingfeng@loongson.cn> > --- > drivers/gpu/drm/drm_atomic_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > index 41b8066f61fff4be..292e38eb621806a0 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -3332,7 +3332,7 @@ EXPORT_SYMBOL(drm_atomic_helper_disable_all); > * that also takes a snapshot of the modeset state to be restored on resume. > * > * This is just a convenience wrapper around drm_atomic_helper_disable_all(), > - * and it is the atomic version of drm_crtc_force_disable_all(). > + * and it is the atomic version of drm_helper_force_disable_all(). > */ > void drm_atomic_helper_shutdown(struct drm_device *dev) > {
On 2023/6/16 21:54, Geert Uytterhoeven wrote: > drm_crtc_force_disable_all() was renamed to > drm_helper_force_disable_all(), but one reference was not updated. > > Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn> > --- > drivers/gpu/drm/drm_atomic_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > index 41b8066f61fff4be..292e38eb621806a0 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -3332,7 +3332,7 @@ EXPORT_SYMBOL(drm_atomic_helper_disable_all); > * that also takes a snapshot of the modeset state to be restored on resume. > * > * This is just a convenience wrapper around drm_atomic_helper_disable_all(), > - * and it is the atomic version of drm_crtc_force_disable_all(). > + * and it is the atomic version of drm_helper_force_disable_all(). > */ > void drm_atomic_helper_shutdown(struct drm_device *dev) > {
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 41b8066f61fff4be..292e38eb621806a0 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -3332,7 +3332,7 @@ EXPORT_SYMBOL(drm_atomic_helper_disable_all); * that also takes a snapshot of the modeset state to be restored on resume. * * This is just a convenience wrapper around drm_atomic_helper_disable_all(), - * and it is the atomic version of drm_crtc_force_disable_all(). + * and it is the atomic version of drm_helper_force_disable_all(). */ void drm_atomic_helper_shutdown(struct drm_device *dev) {
drm_crtc_force_disable_all() was renamed to drm_helper_force_disable_all(), but one reference was not updated. Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/gpu/drm/drm_atomic_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)