| Message ID | 87eendrtv1.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: renesas: enable HDMI Display/Sound on R-Car M3-W+ Salvator-XS | expand |
Hi Morimoto-san, Thank you for the patch. On Tue, Sep 08, 2020 at 09:35:10AM +0900, Kuninori Morimoto wrote: > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch was tested on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > arch/arm64/boot/dts/renesas/r8a77961.dtsi | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > index 423808b6cd58..c7fabd9e875b 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > @@ -2165,8 +2165,19 @@ port@2 { > }; > > du: display@feb00000 { > + compatible = "renesas,du-r8a77961"; > reg = <0 0xfeb00000 0 0x70000>; > - /* placeholder */ > + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > + <&cpg CPG_MOD 722>; > + clock-names = "du.0", "du.1", "du.2"; > + resets = <&cpg 724>, <&cpg 722>; > + reset-names = "du.0", "du.2"; > + > + renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>; > + status = "disabled"; > > ports { > #address-cells = <1>;
Hi Morimoto-san, On 08/09/2020 01:35, Kuninori Morimoto wrote: > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch was tested on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > arch/arm64/boot/dts/renesas/r8a77961.dtsi | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > index 423808b6cd58..c7fabd9e875b 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > @@ -2165,8 +2165,19 @@ port@2 { > }; > > du: display@feb00000 { > + compatible = "renesas,du-r8a77961"; > reg = <0 0xfeb00000 0 0x70000>; > - /* placeholder */ > + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > + <&cpg CPG_MOD 722>; > + clock-names = "du.0", "du.1", "du.2"; > + resets = <&cpg 724>, <&cpg 722>; > + reset-names = "du.0", "du.2"; > + > + renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>; > + status = "disabled"; > > ports { > #address-cells = <1>; >
On Tue, Sep 8, 2020 at 2:35 AM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch was tested on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hi Morimoto-san, On Tue, Sep 8, 2020 at 2:35 AM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch was tested on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > arch/arm64/boot/dts/renesas/r8a77961.dtsi | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > index 423808b6cd58..c7fabd9e875b 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > @@ -2165,8 +2165,19 @@ port@2 { > }; > > du: display@feb00000 { > + compatible = "renesas,du-r8a77961"; > reg = <0 0xfeb00000 0 0x70000>; > - /* placeholder */ > + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > + <&cpg CPG_MOD 722>; > + clock-names = "du.0", "du.1", "du.2"; > + resets = <&cpg 724>, <&cpg 722>; > + reset-names = "du.0", "du.2"; > + > + renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>; > + status = "disabled"; Do you want support for CMMs? Gr{oetje,eeting}s, Geert
Hi Geert > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > > > This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC. > > This patch was tested on R-Car M3-W+ Salvator-XS board. > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > --- (snip) > > du: display@feb00000 { > > + compatible = "renesas,du-r8a77961"; > > reg = <0 0xfeb00000 0 0x70000>; > > - /* placeholder */ > > + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > > + <&cpg CPG_MOD 722>; > > + clock-names = "du.0", "du.1", "du.2"; > > + resets = <&cpg 724>, <&cpg 722>; > > + reset-names = "du.0", "du.2"; > > + > > + renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>; > > + status = "disabled"; > > Do you want support for CMMs? I'm not sure how it works. Thus I dropped such features from initial support. I hope Laurent or Kieran will support it when he received physical board. Some comment for iommu. Thank you for your help !! Best regards --- Kuninori Morimoto
Hi Morimoto-san, On Fri, Sep 11, 2020 at 08:20:56AM +0900, Kuninori Morimoto wrote: > > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > > > > > This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC. > > > This patch was tested on R-Car M3-W+ Salvator-XS board. > > > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > > --- > > (snip) > > > > du: display@feb00000 { > > > + compatible = "renesas,du-r8a77961"; > > > reg = <0 0xfeb00000 0 0x70000>; > > > - /* placeholder */ > > > + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > > > + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, > > > + <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>; > > > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > > > + <&cpg CPG_MOD 722>; > > > + clock-names = "du.0", "du.1", "du.2"; > > > + resets = <&cpg 724>, <&cpg 722>; > > > + reset-names = "du.0", "du.2"; > > > + > > > + renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>; > > > + status = "disabled"; > > > > Do you want support for CMMs? > > I'm not sure how it works. > Thus I dropped such features from initial support. > > I hope Laurent or Kieran will support it > when he received physical board. I'll be happy to do so :-) > Some comment for iommu. > > Thank you for your help !!
diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi index 423808b6cd58..c7fabd9e875b 100644 --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi @@ -2165,8 +2165,19 @@ port@2 { }; du: display@feb00000 { + compatible = "renesas,du-r8a77961"; reg = <0 0xfeb00000 0 0x70000>; - /* placeholder */ + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, + <&cpg CPG_MOD 722>; + clock-names = "du.0", "du.1", "du.2"; + resets = <&cpg 724>, <&cpg 722>; + reset-names = "du.0", "du.2"; + + renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>; + status = "disabled"; ports { #address-cells = <1>;