From patchwork Fri Jul 22 12:22:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9243481 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EB7B6602F0 for ; Fri, 22 Jul 2016 12:22:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DC1C6266F3 for ; Fri, 22 Jul 2016 12:22:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D0AB827FA3; Fri, 22 Jul 2016 12:22:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6AD41266F3 for ; Fri, 22 Jul 2016 12:22:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CCAD86E1F9; Fri, 22 Jul 2016 12:22:13 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.web.de (mout.web.de [212.227.15.3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B1756E1F9 for ; Fri, 22 Jul 2016 12:22:10 +0000 (UTC) Received: from [192.168.1.2] ([77.182.75.73]) by smtp.web.de (mrweb002) with ESMTPSA (Nemesis) id 0LuMAJ-1bIpRM3z8R-011kOx; Fri, 22 Jul 2016 14:22:04 +0200 Subject: [PATCH] drm/qxl: Delete an unnecessary check before drm_gem_object_unreference_unlocked() To: "dri-devel@lists.freedesktop.org" , Daniel Vetter , David Airlie References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> From: SF Markus Elfring Message-ID: <913198fa-2aa4-4804-8616-dd495428c0a5@users.sourceforge.net> Date: Fri, 22 Jul 2016 14:22:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> X-Provags-ID: V03:K0:YO1UG1ZRacP7MF9AKbNuUUKBXoJaH1JyIcd3upZWuiAhse6vYcD 6sbhXOXRvTsk7JInexgYE/+9TYwa2VdHzgvmrfmXeI/riT929LLy2OZEdpsbbatPvNH1iit kniACDyv7MtbdoASLgN1pWK7xYFnby4d3XVSvwxP2vg3GzrsdLi74aqQdo8aZ5L08sXILT0 bkFP+K8N/+aSmFBjVVgEg== X-UI-Out-Filterresults: notjunk:1; V01:K0:6an8ceXl4io=:3w6m6cXUKzS4WH0vm1YleP IurPe1wVl6UwVpopekjq/Y0VEaH8mLDrQ/AWSl6bGTdEoovDZkJ14pvSRq7V1FtjZWS7w7WPm CynUp/euYcN72k+lUOMkJMuITARVem435uJ+JBcftvxJfUT919bM72+09Fdh7w6mGEX+Jr8gc mBuqVAxF0t6arp23cLrjnzac7Ffd4OrPeVb2uVEXneukJ7CKPTq3CQ/huJLjn+7cfWsUG8yph yxnE9iBw0ECiSdRywPPfSOz4qpv3qTNz1kTAQim/0PXEL91RLsCu+3LSF3Rc8GP0cpjRDSiKu LpN7+Rwsp8dn9QntGB+erJzpRCDEgNGf4iPkiG1NGi0IY6/g/GjPaKw2ErIKsCSX5TZisIHfP 3emVKwWMzlfQjnaS7CB5rH2M9JRHFBnaSBS999GOxak9nGFPbV9EvrpRTEuq9N/bqZnRpuIkz rWXu5J6+7xAnr603aE5wzU8/VlRUSlTcCnUwWEJ9eCUMza1hvFmdXWqgQi34MDrTYxRui4s1T 4/WxkLKooDJEAPe8oFVa8n+tyh8Ch6hBt/58eDfMsCh0HgagqAH1R6rat4geIuGOdnSTMv8nr H0T8L/7374Mt14eFAC6jH7jBJMCzdlyybb6fT+2Xlcte59rpNtXVrkBTU2syRzY2cgtVeyvPW xx75qQI/DHRG9HixgE5TYMecORSxDAihcOuaMbpghOg2WerRTHOL0m64K8Y98P6utiSqhnk19 YAiP/e//5Tak1bGn6w7OERts7EYz8s3lzA7gZc7WgUC73GiL7yHXvvRLUwNgZrAUNV3bBIUNt KY8PbsS Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Fri, 22 Jul 2016 14:14:54 +0200 The drm_gem_object_unreference_unlocked() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/qxl/qxl_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index ad42968..3aef127 100644 --- a/drivers/gpu/drm/qxl/qxl_display.c +++ b/drivers/gpu/drm/qxl/qxl_display.c @@ -468,8 +468,7 @@ void qxl_user_framebuffer_destroy(struct drm_framebuffer *fb) { struct qxl_framebuffer *qxl_fb = to_qxl_framebuffer(fb); - if (qxl_fb->obj) - drm_gem_object_unreference_unlocked(qxl_fb->obj); + drm_gem_object_unreference_unlocked(qxl_fb->obj); drm_framebuffer_cleanup(fb); kfree(qxl_fb); }