From patchwork Tue Jun 27 11:56:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Thayer X-Patchwork-Id: 9815689 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DAAC5602B1 for ; Thu, 29 Jun 2017 00:42:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB0BA28497 for ; Thu, 29 Jun 2017 00:42:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BF740284B2; Thu, 29 Jun 2017 00:42:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6B97A28497 for ; Thu, 29 Jun 2017 00:42:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E349B6E5E7; Thu, 29 Jun 2017 00:41:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by gabe.freedesktop.org (Postfix) with ESMTPS id BCC6F6E399 for ; Tue, 27 Jun 2017 11:56:42 +0000 (UTC) Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v5RBuavj018798 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Jun 2017 11:56:37 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.13.8/8.14.4) with ESMTP id v5RBuaci017416 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Jun 2017 11:56:36 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v5RBuYYI026496; Tue, 27 Jun 2017 11:56:34 GMT Received: from [10.165.109.140] (/10.165.109.140) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 27 Jun 2017 04:56:34 -0700 Subject: Re: [PATCH v3] staging: vboxvideo: Add vboxvideo to drivers/staging To: Hans de Goede , Daniel Vetter References: <20170622091137.11852-1-hdegoede@redhat.com> <20170622091137.11852-2-hdegoede@redhat.com> <20170623093104.2tow4aangevonaqr@phenom.ffwll.local> <99dfd921-8eda-132d-e425-4a1c26499b0c@redhat.com> From: Michael Thayer Organization: ORACLE Deutschland B.V. und Co. KG Message-ID: <9cbd1684-6dba-23e6-6f69-8059a0f2d845@oracle.com> Date: Tue, 27 Jun 2017 13:56:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <99dfd921-8eda-132d-e425-4a1c26499b0c@redhat.com> Content-Language: en-GB X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-Mailman-Approved-At: Thu, 29 Jun 2017 00:41:57 +0000 Cc: devel@driverdev.osuosl.org, vbox-dev@virtualbox.org, Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hello Hans, 26.06.2017 18:06, Hans de Goede wrote: > Hi, > > On 23-06-17 11:31, Daniel Vetter wrote: >> On Thu, Jun 22, 2017 at 11:11:37AM +0200, Hans de Goede wrote: [vboxvideo driver submission information to staging.] >> >> In the end it's up to you, but our experience in drm with -staging has >> been that's both a pain (separate tree, which makes coordination harder >> for drm drivers) and a ghetto (no one from drm will look at your >> patches). >> >> Especially for small drivers (and this is one, and I expect if you use >> all >> the latest and greates helpers atomic will provide it'll shrink >> considerably) it's just not worth the pain to polish stuff twice. >> >> 0toh I see the benefit of putting stuff into staging so in the end >> it's up >> to you, just beware pls. > > Thanks for the heads up Daniel, for now I would like to move forward with > getting this in staging, but I do agree that it would be good to get it > into drivers/gpu soon. Michael do you think you will have some time soon > to look at moving this to the atomic helpers ? Taking a look at that now. There is rather a lot of deprecated API use there that I will have to clean up first. The ast driver which I was tracking does not seem to have had much clean-up recently - qxl might have been a better choice. I will also want to get our local code at the level of your v4 submission before I start to avoid creating unneeded difficulties. By the way, see a small, as yet uncommitted fix below. Regards Michael Index: src/VBox/Additions/linux/drm/vbox_fb.c =================================================================== --- src/VBox/Additions/linux/drm/vbox_fb.c (revision 116355) +++ src/VBox/Additions/linux/drm/vbox_fb.c (working copy) @@ -364,6 +364,9 @@ if (fbdev->helper.fbdev) { info = fbdev->helper.fbdev; +#ifdef CONFIG_FB_DEFERRED_IO + fb_deferred_io_cleanup(info); +#endif unregister_framebuffer(info); if (info->cmap.len) fb_dealloc_cmap(&info->cmap);